Skip to content

media: tree-wide: Add missing media_entity_cleanup() calls

Biren Pandya linux-media 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest22 patches 2 repliesIn review
  2. v122 patches 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22media: i2c: cx25840-core: Add missing media_entity_cleanup()drivers/media/i2c/cx25840/cx25840-core.c+2 -00 replies
2/22media: i2c: max9286: Add missing media_entity_cleanup()drivers/media/i2c/max9286.c+4 -10 replies
3/22media: i2c: msp3400-driver: Add missing media_entity_cleanup()drivers/media/i2c/msp3400-driver.c+2 -00 replies
4/22media: i2c: mt9v011: Add missing media_entity_cleanup()drivers/media/i2c/mt9v011.c+3 -00 replies
5/22media: i2c: saa7115: Add missing media_entity_cleanup()drivers/media/i2c/saa7115.c+2 -00 replies
6/22media: platform: stm32-csi: Add missing media_entity_cleanup()drivers/media/platform/st/stm32/stm32-csi.c+2 -01 reply
7/22media: platform: sun4i_csi: Add missing media_entity_cleanup() + fix UAFdrivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c+37 -190 replies
8/22media: platform: microchip-isc-scaler: Add missing media_entity_cleanup()drivers/media/platform/microchip/microchip-isc-base.c drivers/media/platform/microchip/microchip-isc-scaler.c drivers/media/platform/microchip/microchip-isc.h+9 -00 replies
9/22media: platform: cdns-csi2tx: Add missing media_entity_cleanup()drivers/media/platform/cadence/cdns-csi2tx.c+4 -10 replies
10/22media: platform: rcar-csi2: Add missing media_entity_cleanup()drivers/media/platform/renesas/rcar-csi2.c+2 -00 replies
11/22media: platform: csisp: Add missing media_entity_cleanup()drivers/media/platform/renesas/rcar-isp/csisp.c+2 -00 replies
12/22media: platform: rcar-vin: Add missing media_entity_cleanup() + fix UAFdrivers/media/platform/renesas/rcar-vin/rcar-core.c+18 -30 replies
13/22media: platform: rzg2l-cru: Add missing media_entity_cleanup() + fix UAFdrivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c+12 -40 replies
14/22media: platform: cfe: Add missing media_entity_cleanup()drivers/media/platform/raspberrypi/rp1-cfe/cfe.c+2 -00 replies
15/22media: platform: j721e-csi2rx: Add missing media_entity_cleanup()drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c+5 -10 replies
16/22media: platform: hantro_drv: Add missing media_entity_cleanup()drivers/media/platform/verisilicon/hantro_drv.c+9 -31 reply
17/22media: pci: saa7134: Add missing media_entity_cleanup()drivers/media/pci/saa7134/saa7134-core.c+14 -40 replies
18/22media: usb: cx231xx: Add missing media_entity_cleanup()drivers/media/usb/cx231xx/cx231xx-video.c+7 -10 replies
19/22media: usb: em28xx: Add missing media_entity_cleanup()drivers/media/usb/em28xx/em28xx-video.c+11 -20 replies
20/22media: usb: au0828: Add missing media_entity_cleanup()drivers/media/usb/au0828/au0828-video.c+9 -10 replies
21/22media: usb: dvb-usb-v2: Add missing media_entity_cleanup()drivers/media/usb/dvb-usb-v2/mxl111sf.c+20 -10 replies
22/22media: dvb-frontends: au8522_decoder: Add missing media_entity_cleanup()drivers/media/dvb-frontends/au8522_decoder.c+2 -00 replies

Reviews trailers per patch

2 of 22 patches have a Reviewed-by or Acked-by.

PatchBenjamin GaignardAlain Volmat
1/22
2/22
3/22
4/22
5/22
6/22R-b
7/22
8/22
9/22
10/22
11/22
12/22
13/22
14/22
15/22
16/22R-b
17/22
18/22
19/22
20/22
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/22] media: tree-wide: Add missing media_entity_cleanup() calls

This series fixes a widespread API violation across the media subsystem.

The media_entity_pads_init() function initializes the media entity, but many drivers forget to call media_entity_cleanup() in their error paths and remove functions.

This series adds the missing cleanup calls to prevent potential memory leaks and ensure proper resource management.

Fixes tags have been carefully audited. Tags older than 2017 or pointing to directory rename commits have been intentionally omitted to avoid spamming the stable trees for ancient/moved drivers where the bug predates the EOL LTS kernels.

Generated and validated automatically.

Biren Pandya (23):
media: i2c: cx25840-core: Add missing media_entity_cleanup()
media: i2c: max9286: Add missing media_entity_cleanup()
media: i2c: msp3400-driver: Add missing media_entity_cleanup()
media: i2c: mt9v011: Add missing media_entity_cleanup()
media: i2c: saa7115: Add missing media_entity_cleanup()
media: platform: stm32-csi: Add missing media_entity_cleanup()
media: platform: sun4i_csi: Add missing media_entity_cleanup()
media: platform: microchip-isc-scaler: Add missing
media_entity_cleanup()
media: platform: cdns-csi2tx: Add missing media_entity_cleanup()
media: platform: rcar-csi2: Add missing media_entity_cleanup()
media: platform: csisp: Add missing media_entity_cleanup()
media: platform: rcar-core: Add missing media_entity_cleanup()
media: platform: rzg2l-core: Add missing media_entity_cleanup()
media: platform: cfe: Add missing media_entity_cleanup()
media: platform: j721e-csi2rx: Add missing media_entity_cleanup()
media: platform: hantro_drv: Add missing media_entity_cleanup()
media: pci: saa7134: Add missing media_entity_cleanup()
media: usb: cx231xx: Add missing media_entity_cleanup()
media: usb: em28xx: Add missing media_entity_cleanup()
media: usb: au0828: Add missing media_entity_cleanup()
media: usb: dvb-usb-v2: Add missing media_entity_cleanup()
media: dvb-frontends: au8522_decoder: Add missing
media_entity_cleanup()

 drivers/media/dvb-frontends/au8522_decoder.c  |  2 ++
 drivers/media/i2c/cx25840/cx25840-core.c      |  2 ++
 drivers/media/i2c/max9286.c                   |  5 ++++-
 drivers/media/i2c/msp3400-driver.c            |  2 ++
 drivers/media/i2c/mt9v011.c                   |  3 +++
 drivers/media/i2c/saa7115.c                   |  2 ++
 drivers/media/pci/saa7134/saa7134-core.c      | 18 ++++++++++++----
 drivers/media/platform/cadence/cdns-csi2tx.c  |  5 ++++-
 .../platform/microchip/microchip-isc-base.c   |  1 +
 .../platform/microchip/microchip-isc-scaler.c |  7 +++++++
 .../media/platform/microchip/microchip-isc.h  |  1 +
 .../media/platform/raspberrypi/rp1-cfe/cfe.c  |  2 ++
 drivers/media/platform/renesas/rcar-csi2.c    |  2 ++
 .../media/platform/renesas/rcar-isp/csisp.c   |  2 ++
 .../platform/renesas/rcar-vin/rcar-core.c     |  2 ++
 .../platform/renesas/rzg2l-cru/rzg2l-core.c   |  2 ++
 drivers/media/platform/st/stm32/stm32-csi.c   |  2 ++
 .../platform/sunxi/sun4i-csi/sun4i_csi.c      | 10 +++++++--
 .../platform/ti/j721e-csi2rx/j721e-csi2rx.c   |  6 +++++-
 .../media/platform/verisilicon/hantro_drv.c   | 12 ++++++++---
 drivers/media/usb/au0828/au0828-video.c       | 10 ++++++++-
 drivers/media/usb/cx231xx/cx231xx-video.c     |  8 ++++++-
 drivers/media/usb/dvb-usb-v2/mxl111sf.c       | 21 ++++++++++++++++++-
 drivers/media/usb/em28xx/em28xx-video.c       | 13 ++++++++++--
 24 files changed, 123 insertions(+), 17 deletions(-)
Signature · 1 line
2.50.1 (Apple Git-155)