block: invalidate cached plug timestamp on context switch
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first
v2 -> v3 from the cover letter
https://lore.kernel.org/all/[email protected]/
- Add patch 1 to clear PF_BLOCK_TS in copy_process() so the invariant survives fork.
- Drop the if (plug) NULL check inside blk_plug_invalidate_ts(), relying on the invariant established by patch 1. (Peter Zijlstra)
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | kernel/fork: clear PF_BLOCK_TS in copy_process()kernel/ | +1 | 0 replies | |
| 2/2 | block: invalidate cached plug timestamp after task switchinclude/ kernel/ | +14 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] block: invalidate cached plug timestamp on context switch
The details for this are in patch 2. The main reason for this series is to invalidate the cached timestamp on context switch. This was done in sched_update_worker() only before which was resulting in blk-iocost reading stale timestamps and throttling based on wrong information.
Patch 1 is a prerequisite to create the invariant that PF_BLOCK_TS set implies current->plug != NULL.
v2 -> v3:
https://lore.kernel.org/all/[email protected]/
- Add patch 1 to clear PF_BLOCK_TS in copy_process() so the invariant survives fork.
- Drop the if (plug) NULL check inside blk_plug_invalidate_ts(), relying on the invariant established by patch 1. (Peter Zijlstra)
v1 -> v2:
https://lore.kernel.org/all/[email protected]/
- Move the PF_BLOCK_TS check into blk_plug_invalidate_ts() and upgrade it to __always_inline (Peter Zijlstra).
- Drop the tsk parameter; the helper only ever operates on current.
Usama Arif (2):
kernel/fork: clear PF_BLOCK_TS in copy_process()
block: invalidate cached plug timestamp after task switch
include/linux/blkdev.h | 16 ++++++---------- kernel/fork.c | 1 + kernel/sched/core.c | 12 ++++++++---- 3 files changed, 15 insertions(+), 14 deletions(-)
Signature · 1 line
2.53.0-Meta