Skip to content

treewide: remove unreachable memblock_reserve() return value checks in early boot

Sang-Heon Jeon linux-efi linux-mm linux-sh linuxppc-dev lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 3 repliesIn review
  2. v15 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5x86/setup: remove unreachable memblock_reserve() return value checkarch/x86/kernel/setup.c+2 -50 replies
2/5sh: remove unreachable memblock_reserve() return value checkarch/sh/kernel/machine_kexec.c+1 -60 replies
3/5powerpc/fadump: remove unreachable memblock_reserve() return value checksarch/powerpc/kernel/fadump.c+3 -110 replies
4/5xtensa: remove unreachable memblock_reserve() return value checksarch/xtensa/kernel/setup.c+7 -60 replies
5/5Revert "tpm: do not ignore memblock_reserve return value"drivers/firmware/efi/tpm.c+1 -60 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchMukesh Kumar Chaurasiya (IBM)
1/5
2/5
3/5R-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] treewide: remove unreachable memblock_reserve() return value checks in early boot

memblock_reserve() can only return an error after memblock_allow_resize() has been called. Before that it either succeeds or panics, never returning an error.

Before memblock_allow_resize() is called, the return value checks of memblock_reserve() are unreachable and can be removed.

All the call sites are in different trees, so I split the change into one patch per arch/subsystem. The patches are independent and can be applied separately.

---
Changes from v1 [1]
- add reviewed-by tag
- rebased onto latest memblock for-next

[1] https://lore.kernel.org/all/[email protected]/
---
Hello Mike,

Like the previous memblock cleanup series, could you review and take this patch series to the memblock tree?

Thank you for taking valuable time.

Best Regards,
Sang-Heon Jeon
---

Sang-Heon Jeon (5):
x86/setup: remove unreachable memblock_reserve() return value check
sh: remove unreachable memblock_reserve() return value check powerpc/fadump: remove unreachable memblock_reserve() return value
checks
xtensa: remove unreachable memblock_reserve() return value checks Revert "tpm: do not ignore memblock_reserve return value"

 arch/powerpc/kernel/fadump.c   | 14 +++-----------
 arch/sh/kernel/machine_kexec.c |  7 +------
 arch/x86/kernel/setup.c        |  7 ++-----
 arch/xtensa/kernel/setup.c     | 13 +++++++------
 drivers/firmware/efi/tpm.c     |  7 +------
 5 files changed, 14 insertions(+), 34 deletions(-)
Signature · 1 line
2.43.0