accel/tcg: Extract cpu-loop API out of 'exec/cpu-common.h'
Status from this message: Queued except #9, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest11 patches 3 repliesApplied
- v110 patches 14 repliesSuperseded
Changes in v2 from the cover letter
- Do not un-inline cpu_loop_exit_requested()
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | target/arm: Restrict TCG specific headerstarget/ target/ | +5 | 0 replies | |
| 2/11 | hw/s390x/ipl: Remove TCG dependency in handle_diag_308()hw/ target/ target/ +1 more | +22 | 0 replies | |
| 3/11 | accel/tcg: Remove cpu_loop_exit() stubaccel/ accel/ | +0 | 0 replies | |
| 4/11 | accel/tcg: Move cpu_exec() out of 'exec/cpu-common.h'accel/ accel/ bsd-user/ +4 more | +21 | 0 replies | |
| 5/11 | accel/tcg: Move cpu_exec_step_atomic() out of 'exec/cpu-common.h'accel/ accel/ include/ +1 more | +4 | 0 replies | |
| 6/11 | accel/tcg: Move cpu_unwind_state_data() out of 'exec/cpu-common.h'accel/ include/ include/ +3 more | +17 | 0 replies | |
| 7/11 | accel/tcg: Move cpu_restore_state() out of 'exec/cpu-common.h'accel/ accel/ include/ +16 more | +29 | 0 replies | |
| 8/11 | accel/tcg: Have cpu_loop_exit_requested() take const @cpu argumentinclude/ | +1 | 1 reply | |
| 9/11 | accel/tcg: Move cpu_loop_exit_requested() out of 'exec/cpu-common.h'include/ include/ target/ +1 more | +22 | 1 reply | |
| 10/11 | accel/tcg: Move cpu_loop_exit_*() out of 'exec/cpu-common.h'accel/ accel/ accel/ +38 more | +71 | 0 replies | |
| 11/11 | accel/tcg: Restrict headers being TCG specificinclude/ include/ include/ +3 more | +24 | 0 replies |
Reviews trailers per patch
10 of 11 patches have a Reviewed-by or Acked-by.
| Patch | Richard Henderson |
|---|---|
| 1/11 | R-b |
| 2/11 | R-b |
| 3/11 | R-b |
| 4/11 | R-b |
| 5/11 | R-b |
| 6/11 | R-b |
| 7/11 | R-b |
| 8/11 | R-b |
| 9/11 | |
| 10/11 | R-b |
| 11/11 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/11] accel/tcg: Extract cpu-loop API out of 'exec/cpu-common.h'
Missing review: 8 & 9
Since v1:
- Do not un-inline cpu_loop_exit_requested()
We still try to clarify our different APIs, in particular TCG emulation vs hardware accelerators. Extract the TCG vcpu loop methods out of the generic "exec/cpu-common.h" and move them under the 'accel/tcg/' namespace.
Philippe Mathieu-Daudé (11):
target/arm: Restrict TCG specific headers
hw/s390x/ipl: Remove TCG dependency in handle_diag_308() accel/tcg: Remove cpu_loop_exit() stub
accel/tcg: Move cpu_exec() out of 'exec/cpu-common.h' accel/tcg: Move cpu_exec_step_atomic() out of 'exec/cpu-common.h' accel/tcg: Move cpu_unwind_state_data() out of 'exec/cpu-common.h' accel/tcg: Move cpu_restore_state() out of 'exec/cpu-common.h' accel/tcg: Have cpu_loop_exit_requested() take const @cpu argument accel/tcg: Move cpu_loop_exit_requested() out of 'exec/cpu-common.h' accel/tcg: Move cpu_loop_exit_*() out of 'exec/cpu-common.h' accel/tcg: Restrict headers being TCG specific
bsd-user/freebsd/os-proc.h | 1 + include/accel/tcg/cpu-loop.h | 73 ++++++++++++++++++++++++++++ include/accel/tcg/cpu-mmu-index.h | 4 ++ include/accel/tcg/cpu-ops.h | 4 ++ include/accel/tcg/getpc.h | 4 ++ include/accel/tcg/helper-retaddr.h | 4 ++ include/accel/tcg/probe.h | 4 ++ include/accel/tcg/tb-cpu-state.h | 4 ++ include/exec/cpu-common.h | 56 --------------------- include/hw/core/cpu.h | 20 ++++++++ include/user/cpu_loop.h | 2 +- target/arm/internals.h | 4 +- target/s390x/s390x-internal.h | 3 +- accel/stubs/tcg-stub.c | 20 -------- accel/tcg/cpu-exec-common.c | 1 + accel/tcg/cpu-exec.c | 1 + accel/tcg/cputlb.c | 1 + accel/tcg/tb-maint.c | 1 + accel/tcg/tcg-accel-ops-mttcg.c | 1 + accel/tcg/tcg-accel-ops-rr.c | 1 + accel/tcg/tcg-accel-ops.c | 1 + accel/tcg/tcg-runtime.c | 1 + accel/tcg/translate-all.c | 1 + accel/tcg/user-exec.c | 1 + accel/tcg/watchpoint.c | 1 + bsd-user/main.c | 1 + hw/misc/mips_itu.c | 1 + hw/s390x/ipl.c | 5 -- plugins/api.c | 1 + semihosting/console.c | 1 + target/alpha/helper.c | 1 + target/alpha/mem_helper.c | 1 + target/arm/cpu-irq.c | 3 +- target/arm/tcg/helper-a64.c | 2 + target/arm/tcg/op_helper.c | 1 + target/arm/tcg/tlb_helper.c | 1 + target/avr/helper.c | 1 + target/hexagon/op_helper.c | 1 + target/hppa/cpu.c | 1 + target/hppa/mem_helper.c | 1 + target/hppa/op_helper.c | 1 + target/i386/helper.c | 1 + target/i386/tcg/excp_helper.c | 1 + target/i386/tcg/misc_helper.c | 1 + target/i386/tcg/system/bpt_helper.c | 1 + target/i386/tcg/system/misc_helper.c | 1 + target/i386/tcg/system/svm_helper.c | 1 + target/i386/tcg/user/excp_helper.c | 1 + target/i386/tcg/user/seg_helper.c | 1 + target/loongarch/tcg/tcg_cpu.c | 1 + target/loongarch/tcg/tlb_helper.c | 1 + target/m68k/helper.c | 1 + target/m68k/op_helper.c | 1 + target/microblaze/helper.c | 1 + target/microblaze/op_helper.c | 1 + target/mips/tcg/exception.c | 1 + target/mips/tcg/system/tlb_helper.c | 1 + target/or1k/exception_helper.c | 1 + target/or1k/fpu_helper.c | 1 + target/or1k/mmu.c | 1 + target/or1k/sys_helper.c | 1 + target/ppc/tcg-excp_helper.c | 1 + target/ppc/user_only_helper.c | 1 + target/riscv/cpu_helper.c | 1 + target/riscv/csr.c | 1 + target/riscv/op_helper.c | 1 + target/rx/op_helper.c | 1 + target/s390x/diag.c | 32 ++++++------ target/s390x/mmu_helper.c | 3 ++ target/s390x/tcg/cc_helper.c | 1 + target/s390x/tcg/debug.c | 1 + target/s390x/tcg/excp_helper.c | 1 + target/s390x/tcg/mem_helper.c | 2 + target/s390x/tcg/misc_helper.c | 6 ++- target/sh4/helper.c | 1 + target/sh4/op_helper.c | 1 + target/sparc/helper.c | 1 + target/sparc/mmu_helper.c | 1 + target/tricore/helper.c | 1 + target/tricore/op_helper.c | 1 + target/xtensa/exc_helper.c | 1 + target/xtensa/helper.c | 1 + accel/stubs/meson.build | 1 - 83 files changed, 215 insertions(+), 103 deletions(-) create mode 100644 include/accel/tcg/cpu-loop.h delete mode 100644 accel/stubs/tcg-stub.c
Signature · 1 line
2.53.0