Skip to content

Fixes for flip_done timed outs and PSR/Replay corruption

[email protected] amd-gfx stable 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyIn review
  2. v23 patches 2 repliesSuperseded
  3. v13 patches 10 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/amd/display: consolidate DCN vblank/flip handling onto vupdate_no_lockdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c+230 -1900 replies
2/3drm/amd/display: check GRPH_FLIP status before sending eventdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c drivers/gpu/drm/amd/display/dc/core/dc.c +1 more+197 -400 replies
3/3Revert "drm/amd/display: Restore 5s vbl offdelay for NV3x+ DGPUs"drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c+3 -150 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMario Limonciello (AMD)
SeriesT-b R-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] Fixes for flip_done timed outs and PSR/Replay corruption

From: Leo Li <[email protected]>

v1 here:
https://lore.kernel.org/amd-gfx/[email protected]/
v2 here:
https://lore.kernel.org/amd-gfx/[email protected]/

Summary of changes since v2:

* Fixed a regression in kms_vrr@flip-basic, which exposed a scenario in optimistic event delivery where wrong vblank timestamps were attached. See new docstrings in patch 2/3 for details.
* Readability cleanups in patch 2/3, thanks Michel!

v7.0.y based branch here (drops the revert and resolves merge conflicts due to recent refactor of IRQ handlers from amdgpu_dm.c into amdgpu_dm_irq.c):
https://gitlab.freedesktop.org/leoli/linux-asdn/-/commits/lileo/flip_done_timeout_corruption_fixes?ref_type=heads

A Note on LLM use:

Claude helped with code plumbing and IGT testing. The effort of reporting, debugging, spinning up fixes, and testing them, were from humans. Kudos to individuals who collaborated on the amd-gfx mailing list, gitlab, 2026 Display Hackfest, and AMD internal chats, to finally nail down a fix.

Leo Li (3):
drm/amd/display: consolidate DCN vblank/flip handling onto
vupdate_no_lock
drm/amd/display: check GRPH_FLIP status before sending event Revert "drm/amd/display: Restore 5s vbl offdelay for NV3x+ DGPUs"

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 234 +++++++++++---
 .../amd/display/amdgpu_dm/amdgpu_dm_crtc.c    |  70 ++--
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 299 +++++++++---------
 drivers/gpu/drm/amd/display/dc/core/dc.c      |  45 +++
 drivers/gpu/drm/amd/display/dc/dc.h           |   1 +
 5 files changed, 417 insertions(+), 232 deletions(-)

--
2.54.0