Skip to content

mm: Some cleanups for page allocator APIs

Brendan Jackman kvm linux-mm linux-rt-devel lkml 5 versions – In review

Get series with b4
b4 am [email protected] change-id 20260617-alloc-trylock-14ad37dab337

Versions newest first

  1. v5 Latest18 patches 28 repliesIn review 17 of 18 applied
  2. v418 patches 9 repliesSuperseded
  3. v316 patches 42 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v213 patches41 repliesSuperseded
v11 patch14 repliesSuperseded

Changes in v5 from the cover letter

- Just trivial non-functional fixes.
- Link to v4: https://patch.msgid.link/[email protected]

Patches in v5 17 of 18 applied

#Subject and filesSizeRepliesApplied
1/18mm/page_alloc: rename ALLOC_TRYLOCK -> ALLOC_NOLOCKmm/internal.h mm/page_alloc.c+6 -61 replyApplied
2/18mm/page_alloc: some renames to clarify alloc_flags scopesinclude/linux/skbuff.h mm/page_alloc.c+15 -151 replyApplied
3/18mm: name some args in a function declarationmm/internal.h+2 -21 replyApplied
4/18mm: Split out internal page_alloc.hMAINTAINERS mm/compaction.c mm/hugetlb.c +19 more+289 -2551 reply
5/18mm/page_alloc: unify __alloc_frozen_pages[_nolock]_noprof()mm/hugetlb.c mm/mempolicy.c mm/page_alloc.c +2 more+117 -1002 repliesApplied
6/18mm/page_alloc: relax GFP WARN in nolock allocsmm/page_alloc.c+2 -11 replyApplied
7/18mm: move some stuff to mm/page_alloc.hinclude/linux/gfp.h mm/page_alloc.h mm/vmstat.c+28 -261 replyApplied
8/18perf/x86/intel: Use higher-level allocator APIarch/x86/events/intel/ds.c+3 -31 replyApplied
9/18KVM: VMX: Use higher-level allocator APIarch/x86/kvm/vmx/vmx.c+1 -12 repliesApplied
10/18x86/virt: Use higher-level allocator APIarch/x86/virt/hw.c+1 -11 replyApplied
11/18sgi-xp: Use higher-level allocator APIdrivers/misc/sgi-xp/xpc_uv.c+2 -31 replyApplied
12/18net/funeth: Switch to higher-level allocator APIdrivers/net/ethernet/fungible/funeth/funeth_rx.c+1 -11 replyApplied
13/18mm: Remove __alloc_pages_node()include/linux/gfp.h+4 -166 repliesApplied
14/18mm: Move __alloc_pages() to mm/page_alloc.hDocumentation/admin-guide/cgroup-v1/cpusets.rst Documentation/admin-guide/mm/transhuge.rst include/linux/gfp.h +2 more+19 -181 replyApplied
15/18mm: replace __GFP_NO_CODETAG with ALLOC_NO_CODETAGinclude/linux/alloc_tag.h mm/alloc_tag.c mm/compaction.c +3 more+55 -460 repliesApplied
16/18mm: remove the __GFP_NO_OBJ_EXT flaginclude/linux/gfp_types.h include/trace/events/mmflags.h tools/include/linux/gfp_types.h+1 -231 replyApplied
17/18mm/page_alloc: drop alloc_flags arg from alloc_flags_cma()mm/page_alloc.c+6 -71 replyApplied
18/18mm: factor out can_spin_trylock()mm/internal.h mm/page_alloc.c mm/slub.c+25 -251 replyApplied

Reviews trailers per patch

All 18 patches have a Reviewed-by or Acked-by.

PatchSuren BaghdasaryanHarry Yoo (Oracle)Vlastimil Babka (SUSE)JP KobrynGreg Kroah-HartmanSteve WahlHao GeZi YanSean Christopherson
1/18R-b R-b R-b A-b
2/18R-b A-b R-b
3/18R-b R-b
4/18R-b A-b
5/18R-b A-b
6/18R-b A-b R-b A-b
7/18R-b R-b
8/18R-b R-b R-b
9/18R-b R-b R-b A-b
10/18R-b R-b R-b
11/18R-b R-b A-b A-b R-b
12/18R-b R-b R-b
13/18R-b R-b R-b
14/18R-b R-b
15/18R-b T-b A-b
16/18A-b
17/18R-b R-b
18/18R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 9 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/18] mm: Some cleanups for page allocator APIs

Based on mm-new.

This depends on moving alloc_tag to mm/:
https://lore.kernel.org/all/aj5QBtJcphPElczI@lucifer/

Some tweaks and cleanups for page allocator entrypoint and flags. This is motivated by preparation for __GFP_UNMAPPED [1] (which will probably become ALLOC_UNMAPPED in its next iteration), but all this is supposed to be an improvement to the codebase in its own right: unifying code paths, reducing API surface, and removing GFP flags.

[1] https://lore.kernel.org/all/[email protected]/

This started with unifying __alloc_frozen_pages[_nolock]_noprof() and expanded from there.

Unifying the nolock allocator entrypoint with the normal allocator entrypoint means adding an alloc_flags argument to the later (only exposed within mm/). This presents an opportunity to take advantage of that arg to remove some GFP flags, if we add that alloc_flags arg a bit more broadly to allocator entrypoints.

To distinguish between mm-internal and "public" allocator entrypoints, it makes sense to use the __ prefix. There are already some public APIs with that prefix. For *alloc_pages*, just removing those variants seems like a nice cleanup anyway, so do that. For get_free_pages, the "__" variant is the _only_ variant and it's very widely used, so it doesn't seem worthwhile to modify that. Therefore, scope this "__" change specifically to the *alloc_pages* API, which means we leave the *folio_alloc* API untouched too, even though that could probably be cleaned up if so desired.

Tested:

- KVM, mm, and BPF selftests in a QEMU VM

- kunit.py on x86_64

- For the ALLOC_NO_CODETAG bits I just booted a VM and read /proc/allocinfo. I confirmed that if I remove ALLOC_NO_CODETAG, the kernel crashes in early boot, so I was at least booting code that depends on this logic.

I used Google's internal version of Antigravity (AI coding harness) to do the repetitive bits, those commits are marked with Assisted-by, the rest is manual.

---
Changes in v5:
- Just trivial non-functional fixes.
- Link to v4: https://patch.msgid.link/[email protected]

Changes in v4:
- Fixed some (harmless) missing applications of ac->alloc_flags (local Sashiko)
- Fixed various build issues.
- Note that Sashiko pointed out a KMSAN build issue [0], I have

     fixed it but KMSAN builds are currently broken by objtool [1]. At least
     mm/kmsan/init.c compiles.
     [2] https://lore.kernel.org/all/[email protected]/
     [3] https://lore.kernel.org/all/[email protected]/t/#u

- Avoided setting ALLOC_NOFRAGMENT under ALLOC_NOLOCK (Sashiko, Harry)
- Added patch to tweak alloc_flags_cma() interface (Vlastimil)
- More commit messages fixups (various)
- Added patch to create can_spin_trylock() (Harry)
- Link to v3: https://patch.msgid.link/[email protected]

Changes in v3:
- Created mm/page_alloc.h
- Fixed EXPORT_SYMBOL() issues
- Reworded commit messages per Sashiko's pointers
- Dropped rename of alloc_flags arg in prepare_alloc_pages() (Suren)
- Renamed gfp_to_alloc_flags_nonblocking() too after rebasing onto:
https://lore.kernel.org/all/[email protected]/
- Link to v2: https://patch.msgid.link/[email protected]

Changes in v2:
- Fixed up whitespace in nolock unification patch
- Introduced ALLOC_DEFAULT to replace literal 0 for alloc_flags
- All other patches are new
- Link to v1: https://patch.msgid.link/[email protected]

---
Brendan Jackman (17):
mm/page_alloc: rename ALLOC_TRYLOCK -> ALLOC_NOLOCK mm/page_alloc: some renames to clarify alloc_flags scopes
mm: name some args in a function declaration
mm: Split out internal page_alloc.h mm/page_alloc: unify __alloc_frozen_pages[_nolock]_noprof() mm/page_alloc: relax GFP WARN in nolock allocs
mm: move some stuff to mm/page_alloc.h perf/x86/intel: Use higher-level allocator API
KVM: VMX: Use higher-level allocator API x86/virt: Use higher-level allocator API
sgi-xp: Use higher-level allocator API net/funeth: Switch to higher-level allocator API
mm: Remove __alloc_pages_node()
mm: Move __alloc_pages() to mm/page_alloc.h
mm: replace __GFP_NO_CODETAG with ALLOC_NO_CODETAG mm/page_alloc: drop alloc_flags arg from alloc_flags_cma()
mm: factor out can_spin_trylock()

Vlastimil Babka (SUSE) (1):
mm: remove the __GFP_NO_OBJ_EXT flag

 Documentation/admin-guide/cgroup-v1/cpusets.rst  |   2 +-
 Documentation/admin-guide/mm/transhuge.rst       |   2 +-
 MAINTAINERS                                      |   1 +
 arch/x86/events/intel/ds.c                       |   6 +-
 arch/x86/kvm/vmx/vmx.c                           |   2 +-
 arch/x86/virt/hw.c                               |   2 +-
 drivers/misc/sgi-xp/xpc_uv.c                     |   5 +-
 drivers/net/ethernet/fungible/funeth/funeth_rx.c |   2 +-
 include/linux/alloc_tag.h                        |   4 +-
 include/linux/gfp.h                              |  54 +---
 include/linux/gfp_types.h                        |   7 -
 include/linux/skbuff.h                           |   2 +-
 include/trace/events/mmflags.h                   |  10 +-
 mm/alloc_tag.c                                   |  23 +-
 mm/compaction.c                                  |   5 +-
 mm/hugetlb.c                                     |   4 +-
 mm/internal.h                                    | 275 ++------------------
 mm/khugepaged.c                                  |   1 +
 mm/kmsan/init.c                                  |   2 +-
 mm/memory-failure.c                              |   1 +
 mm/memory_hotplug.c                              |   1 +
 mm/mempolicy.c                                   |  11 +-
 mm/migrate.c                                     |   1 +
 mm/mm_init.c                                     |   1 +
 mm/page_alloc.c                                  | 269 ++++++++++---------
 mm/page_alloc.h                                  | 312 +++++++++++++++++++++++
 mm/page_frag_cache.c                             |   6 +-
 mm/page_isolation.c                              |   1 +
 mm/page_owner.c                                  |   2 +-
 mm/page_reporting.c                              |   1 +
 mm/show_mem.c                                    |   1 +
 mm/shuffle.c                                     |   1 +
 mm/slub.c                                        |  17 +-
 mm/swap.c                                        |   1 +
 mm/vmscan.c                                      |   1 +
 mm/vmstat.c                                      |   1 +
 tools/include/linux/gfp_types.h                  |   7 -
 37 files changed, 536 insertions(+), 508 deletions(-)

---
base-commit: 32af3ff0925368eff29b2fed62f154150eb5dc10
change-id: 20260617-alloc-trylock-14ad37dab337

Best regards,

Signature · 1 line
Brendan Jackman <[email protected]>