Skip to content

drm/sysfb: Fix visible size and related checks

Thomas Zimmermann dri-devel sashiko-reviews stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- fix trunctions from type conversions (sashiko)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/sysfb: Do not page-align visible size of the framebufferdrivers/gpu/drm/sysfb/drm_sysfb_screen_info.c+1 -10 replies
2/4drm/sysfb: Avoid possible truncation with calculating visible sizedrivers/gpu/drm/sysfb/drm_sysfb_screen_info.c+2 -11 reply
3/4drm/sysfb: Return errno code from drm_sysfb_get_visible_size()drivers/gpu/drm/sysfb/drm_sysfb_helper.h drivers/gpu/drm/sysfb/drm_sysfb_screen_info.c drivers/gpu/drm/sysfb/efidrm.c +1 more+9 -80 replies
4/4drm/sysfb: Avoid truncating maximum stridedrivers/gpu/drm/sysfb/drm_sysfb_screen_info.c+7 -11 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchJavier Martinez Canillas
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] drm/sysfb: Fix visible size and related checks

We need the system framebuffer's visible size in efidrm and vesadrm. Fix the size calculation for some corner cases and handle errors correctly.

v2:
- fix trunctions from type conversions (sashiko)

Thomas Zimmermann (4):
drm/sysfb: Do not page-align visible size of the framebuffer drm/sysfb: Avoid possible truncation with calculating visible size drm/sysfb: Return errno code from drm_sysfb_get_visible_size() drm/sysfb: Avoid truncating maximum stride

 drivers/gpu/drm/sysfb/drm_sysfb_helper.h      |  2 +-
 drivers/gpu/drm/sysfb/drm_sysfb_screen_info.c | 13 ++++++++++---
 drivers/gpu/drm/sysfb/efidrm.c                |  7 ++++---
 drivers/gpu/drm/sysfb/vesadrm.c               |  6 +++---
 4 files changed, 18 insertions(+), 10 deletions(-)

base-commit: fc59f76558703febba8056be87d1c97d14f7485e

Signature · 1 line
2.54.0