Skip to content

selftests/bpf: libarena cleanup and bitmap struct

Emil Tsalapatis bpf sashiko-reviews 4 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/26 patches 3 repliesApplied 6/6
  2. v3 posting 1/25 patches 2 repliesSuperseded
  3. v25 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches12 repliesSuperseded

Patches in v3 posting 2/2 All 6 applied

#Subject and filesSizeRepliesApplied
1/6selftests/bpf: libarena: Replace leftover st_ prefix with test_tools/testing/selftests/bpf/libarena/selftests/test_asan_buddy.bpf.c tools/testing/selftests/bpf/libarena/selftests/test_asan_common.h tools/testing/selftests/bpf/libarena/selftests/test_buddy.bpf.c+1 -10 repliesApplied
2/6selftests/bpf: libarena: Fix can-loop zero variable definitiontools/testing/selftests/bpf/libarena/include/libarena/common.h tools/testing/selftests/bpf/libarena/selftests/test_asan_buddy.bpf.c tools/testing/selftests/bpf/libarena/selftests/test_buddy.bpf.c +2 more+18 -120 repliesApplied
3/6selftests/bpf: libarena: Clean up allocation state before buddy teststools/testing/selftests/bpf/libarena/src/common.bpf.c tools/testing/selftests/bpf/prog_tests/libarena.c tools/testing/selftests/bpf/prog_tests/libarena_asan.c+18 -40 repliesApplied
4/6selftests/bpf: Add arena-based bitmap data structuretools/testing/selftests/bpf/libarena/include/libarena/bitmap.h tools/testing/selftests/bpf/libarena/src/bitmap.bpf.c+279 -03 repliesApplied
5/6selftests/bpf: libarena: Add bitmap selfteststools/testing/selftests/bpf/libarena/selftests/test_bitmap.bpf.c+394 -00 repliesApplied
6/6selftests/bpf: libarena: Add parallel bitmap selftesttools/testing/selftests/bpf/libarena/selftests/test_parallel_bitmap.bpf.c+190 -00 repliesApplied

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchIhor SolodraiEduard Zingerman
1/6A-b
2/6A-b
3/6A-b
4/6
5/6A-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH RESEND bpf-next v3 0/6] selftests/bpf: libarena cleanup and bitmap struct

Cleanup patches for libarena, along with a new bitmap data type that is in use by sched-ext. Patch 1 is an NFC that properly renames the buddy selftests for consistency. Patch 2 fixes the zero variable used in libarena for can_loop based looping, and afterwrds removes all bpf_for() instances from the code. Patch 3 fixes an (untriggered) edge case that could cause spurious selftest failures. Finally, patches 4 to 6 introduce the bitmap data structure along with selftests.

CHANGELOG
=========

v3 was resent as the first submission was missing the first patch.

v2 -> v3: (https://lore.kernel.org/bpf/[email protected])
- Remove unused macros and fix typo in commit message (AI)

v1 -> v2: (https://lore.kernel.org/bpf/[email protected])

- Added acks by Ihor and Eduard
- Fix missing commit message (Ihor)
- Enforce 64 bits per cell with BITS_TO_LONG_LONG (Sashiko)
- Add test for bmp_copy (Ihor)
- Add atomic versions of _set() and _clear() (Ihor) and add a parallel selftest for them.

Emil Tsalapatis (6):
selftests/bpf: libarena: Replace leftover st_ prefix with test_ selftests/bpf: libarena: Fix can-loop zero variable definition selftests/bpf: libarena: Clean up allocation state before buddy tests selftests/bpf: Add arena-based bitmap data structure selftests/bpf: libarena: Add bitmap selftests selftests/bpf: libarena: Add parallel bitmap selftest

 .../bpf/libarena/include/libarena/bitmap.h    |  34 ++
 .../bpf/libarena/include/libarena/common.h    |   2 +-
 ...asan_buddy.bpf.c => test_asan_buddy.bpf.c} |  10 +-
 .../{st_asan_common.h => test_asan_common.h}  |   0
 .../bpf/libarena/selftests/test_bitmap.bpf.c  | 394 ++++++++++++++++++
 .../{st_buddy.bpf.c => test_buddy.bpf.c}      |   8 +-
 .../selftests/test_parallel_bitmap.bpf.c      | 190 +++++++++
 .../selftests/test_parallel_spmc.bpf.c        |   9 +-
 .../selftests/bpf/libarena/src/bitmap.bpf.c   | 245 +++++++++++
 .../selftests/bpf/libarena/src/common.bpf.c   |   9 +-
 .../selftests/bpf/prog_tests/libarena.c       |   8 +-
 .../selftests/bpf/prog_tests/libarena_asan.c  |   8 +-
 12 files changed, 900 insertions(+), 17 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/libarena/include/libarena/bitmap.h
 rename tools/testing/selftests/bpf/libarena/selftests/{st_asan_buddy.bpf.c => test_asan_buddy.bpf.c} (98%)
 rename tools/testing/selftests/bpf/libarena/selftests/{st_asan_common.h => test_asan_common.h} (100%)
 create mode 100644 tools/testing/selftests/bpf/libarena/selftests/test_bitmap.bpf.c
 rename tools/testing/selftests/bpf/libarena/selftests/{st_buddy.bpf.c => test_buddy.bpf.c} (97%)
 create mode 100644 tools/testing/selftests/bpf/libarena/selftests/test_parallel_bitmap.bpf.c
 create mode 100644 tools/testing/selftests/bpf/libarena/src/bitmap.bpf.c
Signature · 1 line
2.54.0