Skip to content

ASoC: Intel: Convert locking to guard()/scoped_guard()

[email protected] linux-sound lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 6 repliesIn review
  2. v35 patches 13 repliesSuperseded
  3. v24 patches 5 repliesSuperseded

Changes in v4 from the cover letter

- Add cleanup.h include where needed.
- Remove unnecessary variables.
- Reorder patches in the series.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ASoC: Intel: avs: Use guard() for lockingsound/soc/intel/avs/apl.c sound/soc/intel/avs/control.c sound/soc/intel/avs/core.c +4 more+39 -760 replies
2/5ASoC: Intel: avs: Use scoped_guard() for scoped lockingsound/soc/intel/avs/debugfs.c sound/soc/intel/avs/ipc.c sound/soc/intel/avs/loader.c+42 -420 replies
3/5ASoC: intel: atom: Use __free(kfree) for stream pointersound/soc/intel/atom/sst-mfld-platform-pcm.c+14 -60 replies
4/5ASoC: Intel: atom: Use guard() for lockingsound/soc/intel/atom/sst-atom-controls.c sound/soc/intel/atom/sst-mfld-platform-pcm.c sound/soc/intel/atom/sst/sst_ipc.c +1 more+23 -450 replies
5/5ASoC: Intel: atom: Use scoped_guard() for scoped lockingsound/soc/intel/atom/sst-atom-controls.c sound/soc/intel/atom/sst-mfld-platform-pcm.c+27 -310 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchCezary Rojewski
SeriesR-b
1/5
2/5
3/5
4/5R-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] ASoC: Intel: Convert locking to guard()/scoped_guard()

From: bui duc phuc <[email protected]>

Hi all,

This series converts mutex and spinlock handling in Intel ASoC drivers to use guard()/scoped_guard() helpers.

Most changes are straightforward conversions intended to simplify lock handling and cleanup paths, with no intended functional changes.

The series has been compile-tested only.

Link v1:
https://lore.kernel.org/all/[email protected]/

Link v2:
https://lore.kernel.org/all/[email protected]/

Link v3:
https://lore.kernel.org/all/CAABR9nGB9Z-caMwubqNAY1W9OwM6ZiFWqrqATJP9NtyNBbkL4Q@mail.gmail.com/

Changes in v2:
- Reduce the series from 20 patches to 4 patches.
- Drop smaller conversions that did not provide clear benefits.

Changes in v3:
- Drop the scoped_guard() conversion for the function that still used a goto-based cleanup path.
- Move the __free(kfree) conversion into a separate patch.

Changes in v4:
- Add cleanup.h include where needed.
- Remove unnecessary variables.
- Reorder patches in the series.

Best regards,
Phuc

bui duc phuc (5):
ASoC: Intel: avs: Use guard() for locking
ASoC: Intel: avs: Use scoped_guard() for scoped locking
ASoC: intel: atom: Use __free(kfree) for stream pointer
ASoC: Intel: atom: Use guard() for locking
ASoC: Intel: atom: Use scoped_guard() for scoped locking

 sound/soc/intel/atom/sst-atom-controls.c     | 67 +++++++++-----------
 sound/soc/intel/atom/sst-mfld-platform-pcm.c | 59 ++++++++---------
 sound/soc/intel/atom/sst/sst_ipc.c           |  5 +-
 sound/soc/intel/atom/sst/sst_pvt.c           |  9 ++-
 sound/soc/intel/avs/apl.c                    |  8 +--
 sound/soc/intel/avs/control.c                |  7 +-
 sound/soc/intel/avs/core.c                   |  4 +-
 sound/soc/intel/avs/debug.h                  | 10 +--
 sound/soc/intel/avs/debugfs.c                | 19 +++---
 sound/soc/intel/avs/ipc.c                    | 59 ++++++++---------
 sound/soc/intel/avs/loader.c                 | 15 +++--
 sound/soc/intel/avs/path.c                   | 30 +++------
 sound/soc/intel/avs/utils.c                  | 45 +++++--------
 13 files changed, 141 insertions(+), 196 deletions(-)
Signature · 1 line
2.43.0