Skip to content

ipv6: fix error handling in disable_ipv6 sysctl

Fernando Fernandez Mancera netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 1 replyApplied 6/6
  2. v27 patches 3 repliesSuperseded 6 of 7 applied
  3. v16 patches 10 repliesSuperseded

Changes from the cover letter

v3: Patch 7: dropped from the series based on Ido's feedback

Patches in v3 All 6 applied

#Subject and filesSizeRepliesApplied
1/6ipv6: fix error handling in disable_ipv6 sysctlnet/ipv6/addrconf.c+2 -00 repliesApplied
2/6ipv6: fix error handling in ignore_routes_with_linkdown sysctlnet/ipv6/addrconf.c+2 -00 repliesApplied
3/6ipv6: fix error handling in forwarding sysctlnet/ipv6/addrconf.c+3 -10 repliesApplied
4/6ipv6: fix error handling in disable_policy sysctlnet/ipv6/addrconf.c+2 -00 repliesApplied
5/6ipv6: fix state corruption during proxy_ndp sysctl restartnet/ipv6/addrconf.c+7 -70 repliesApplied
6/6ipv6: fix missing notification for ignore_routes_with_linkdownnet/ipv6/addrconf.c+12 -60 repliesApplied

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNicolas DichtelIdo Schimmel
SeriesR-b
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net v3 0/6] ipv6: fix error handling in disable_ipv6 sysctl

While working on a different IPv6 patch series I have spotted multiple minor bugs around sysctl error handling and notifications. In general, they are not serious issues.

In addition, there is one more issue in forwarding sysctl as it does not check for CAP_NET_ADMIN for the namespace. I am keeping that patch out of this series and I am aiming it at the net-next tree once it re-opens.

During v3, Ido's pointed out that it is unnecessary to reset the position pointer when the return value is negative as at new_sync_write() the ppos is only advanced when ret return value is positive. That means we can get rid of that operation in ipv4/ipv6 sysctls. That is going to be sent to net-next too.

Changes:
v3: Patch 7: dropped from the series based on Ido's feedback

v2: https://lore.kernel.org/netdev/[email protected]/
Patch 3: fix return code of addrconf_fixup_forwarding() Patch 5: acquire lock before calling proc_dointvec()
Patch 7: new on this revision of the series

Fernando Fernandez Mancera (6):
ipv6: fix error handling in disable_ipv6 sysctl
ipv6: fix error handling in ignore_routes_with_linkdown sysctl
ipv6: fix error handling in forwarding sysctl
ipv6: fix error handling in disable_policy sysctl
ipv6: fix state corruption during proxy_ndp sysctl restart
ipv6: fix missing notification for ignore_routes_with_linkdown

 net/ipv6/addrconf.c | 42 ++++++++++++++++++++++++++++--------------
 1 file changed, 28 insertions(+), 14 deletions(-)
Signature · 1 line
2.54.0