Skip to content

RFC smb/client: improve change notify support

ChenXiaoSong linux-cifs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2smb/client: introduce smb3_notify_open()fs/smb/client/smb2ops.c+45 -260 replies
2/2smb/client: do not call SMB2_close() in smb3_notify()fs/smb/client/smb2ops.c+58 -250 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/2] smb/client: improve change notify support

From: ChenXiaoSong <[email protected]>

I still need to do more debugging on this patchset, for example to check whether there is any race between ioctl(CIFS_IOC_NOTIFY_INFO) and readdir(). Maybe I can send this patchset to the mailing list first to get more suggestions from others.

Before this patchset, when an operation on the server triggered multiple actions, the client received only one action notification.

After this patchset, the client can receive all action notifications.

Example:

smbinfo notify /mnt

# server: touch /export/file1
Notifications received, returned data_len is 24
Action: 0x00000001, FileName: file1
Notifications received, returned data_len is 24
Action: 0x00000003, FileName: file1

# server: mv /export/file1 /export/file2
Notifications received, returned data_len is 48
Action: 0x00000004, FileName: file1
Action: 0x00000005, FileName: file2
Notifications received, returned data_len is 24
Action: 0x00000003, FileName: file2
Notifications received, returned data_len is 24
Action: 0x00000002, FileName: file1

ChenXiaoSong (2):
smb/client: introduce smb3_notify_open() smb/client: do not call SMB2_close() in smb3_notify()

 fs/smb/client/smb2ops.c | 120 ++++++++++++++++++++++++++++------------
 1 file changed, 86 insertions(+), 34 deletions(-)
Signature · 1 line
2.54.0