Skip to content

pkey: Fix for PKEY_VERIFYPROTK ioctl

Holger Dengler linux-s390 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest1 patch 2 repliesApplied
  2. v21 patch 4 repliesSuperseded
  3. v11 patch 8 repliesSuperseded

Changes in v3 from the cover letter

- Re-phrase the commit message and summary line
- Pick R-b

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/1pkey: Move keytype check from pkey api to handlerdrivers/s390/crypto/pkey_api.c+1 -102 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchIngo FranzkiHarald Freudenberger
1/1R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/1] pkey: Fix for PKEY_VERIFYPROTK ioctl

The PKEY_VERIFYPROTK ioctl is used to verify protected key blobs. The verification is mainly done y the called handler implementations. The following patch 1/1 removes the (broken) length check in the generic API code. The deep-inspection of the key blob is handler-specific.

The v1 of this series has fixed the length calculation for the keysize, so that the correct keytype can be derived from it. But this is a violation of the layering in pkey, where only the handlers should have a deep knowledge of the key blobs. Therefore, v2 now removes the keysize calculation and the keytype check, as it is always done by the handler.

The v2 has been rebased to the current master, as it adds a missing length check for the ioctl request structure. This addresses one comment of the Sashiko AI review.

Changes since v2:
- Re-phrase the commit message and summary line
- Pick R-b

Changes since v1:
- Remove the keytype check (instead of fix the length calculation)
- Add stable tag
- Rebase to current master

The patch applies to Linus' master branch.

Holger Dengler (1):
pkey: Move keytype check from pkey api to handler

 drivers/s390/crypto/pkey_api.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

base-commit: 502d801f0ab03e4f32f9a33d203154ce84887921

Signature · 1 line
2.54.0