Skip to content

drm/sysfb: simpledrm: Various improvements

Thomas Zimmermann dri-devel sashiko-reviews stable 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 8 repliesIn review
  2. v26 patches 13 repliesSuperseded
  3. v13 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- use shared helper for parsing the panel orentation (Thierry)
- fix framebuffer size checks (Sashiko)
- minor improvements

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/sysfb: simpledrm: Improve framebuffer-size validationdrivers/gpu/drm/sysfb/simpledrm.c+4 -110 replies
2/7drm/sysfb: simpledrm: Improve panel-size validationdrivers/gpu/drm/sysfb/simpledrm.c+46 -30 replies
3/7drm/sysfb: simpledrm: Inline simplefb_get_validated_int()drivers/gpu/drm/sysfb/simpledrm.c+2 -90 replies
4/7drm/sysfb: simpledrm: Improve stride validationdrivers/gpu/drm/sysfb/simpledrm.c+8 -20 replies
5/7drm/sysfb: simpledrm: Validate mmap size against framebuffer sizedrivers/gpu/drm/sysfb/simpledrm.c+24 -00 replies
6/7drm/of: Implement drm_of_get_panel_orientation()drivers/gpu/drm/drm_of.c drivers/gpu/drm/drm_panel.c include/drm/drm_of.h+57 -245 replies
7/7drm/sysfb: simpledrm: Read panel orientation from DT nodedrivers/gpu/drm/sysfb/simpledrm.c+9 -21 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchThierry RedingMaxime RipardJavier Martinez Canillas
SeriesR-b R-b
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/7] drm/sysfb: simpledrm: Various improvements

Patches 1 to 5 improve validation of the values provided by the device firmware.

Patches 6 and 7 improve support for panel orientation. There's a rotation property in the DT panel node. Read the value and set the connector's orientation property accordingly. To do so, patch 6 moves the existing code for parsing the rotation to drm_of.c. This makes it available to simpledrm without introducing a dependency on DRM_PANEL.

v3:
- use shared helper for parsing the panel orentation (Thierry)
- fix framebuffer size checks (Sashiko)
- minor improvements
v2:
- further improve input validation (Sashiko)

Thomas Zimmermann (7):
drm/sysfb: simpledrm: Improve framebuffer-size validation drm/sysfb: simpledrm: Improve panel-size validation drm/sysfb: simpledrm: Inline simplefb_get_validated_int() drm/sysfb: simpledrm: Improve stride validation drm/sysfb: simpledrm: Validate mmap size against framebuffer size drm/of: Implement drm_of_get_panel_orientation() drm/sysfb: simpledrm: Read panel orientation from DT node

 drivers/gpu/drm/drm_of.c          |  44 +++++++++++
 drivers/gpu/drm/drm_panel.c       |  26 +------
 drivers/gpu/drm/sysfb/simpledrm.c | 120 +++++++++++++++++++++++-------
 include/drm/drm_of.h              |  11 +++
 4 files changed, 150 insertions(+), 51 deletions(-)

base-commit: fc59f76558703febba8056be87d1c97d14f7485e

Signature · 1 line
2.54.0