Skip to content

netfs: Miscellaneous fixes

David Howells ceph-devel linux-cifs linux-fsdevel lkml netfs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11netfs: Fix decision whether to disallow write-streaming due to fscache usefs/netfs/buffered_write.c fs/netfs/internal.h+13 -10 replies
2/11cachefiles: Fix double fputfs/cachefiles/namei.c+0 -10 replies
3/11cachefiles: Fix file burial to take lock when unsetting S_KERNEL_FILEfs/cachefiles/namei.c+1 -10 replies
4/11iov_iter: Fix potential underflow in iov_iter_extract_xarray_pages()lib/iov_iter.c+9 -00 replies
5/11iov_iter: Fix missing alloc fail check in iov_iter_extract_bvec_pages()lib/iov_iter.c+2 -00 replies
6/11iov_iter: Fix a memory leak in iov_iter_extract_user_pages()lib/iov_iter.c+8 -10 replies
7/11iov_iter: Remove unused variable in kunit_iov_iter.clib/tests/kunit_iov_iter.c+2 -30 replies
8/11scatterlist: Fix offset in folio calc in extract_xarray_to_sg()lib/scatterlist.c+1 -00 replies
9/11netfs: Fix kdoc warninginclude/linux/netfs.h+1 -10 replies
10/11netfs: Replace wb_lock with a bit lock for asynchronicityfs/afs/symlink.c fs/netfs/locking.c fs/netfs/write_collect.c +2 more+126 -310 replies
11/11netfs: Fix writethrough to use collection offloadfs/netfs/write_issue.c+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/11] netfs: Miscellaneous fixes

Hi Christian,

Here are some miscellaneous fixes for netfslib. I separated them from my netfs-next branch. Various Sashiko review comments[1][2] are addressed:

(1) Fix the decision whether to disallow write-streaming due to fscache use.

(2) Fix a double fput in cachefiles_create_tmpfile().

(3) Fix alteration of S_KERNEL_FILE inode flag without holding inode lock.

(4) Fix a potential mathematical underflow in iov_iter_extract_xarray_pages() and make it return 0 and free the array if no pages could be extracted.

(5) Fix a missing alloc failure check in iov_iter_extract_bvec_pages().

(6) Fix iov_iter_extract_user_pages() so that it doesn't leak the pages array if it returns an error or 0 (inasmuch as the leak is really in the callers).

(7) Remove an unused variable in kunit_iov_iter.c.

(8) Fix extract_xarray_to_sg() to calculate folio offset correctly.

(9) Fix a kdoc comment.

(10) Replace the netfs_inode::wb_lock mutex with a bit lock so that the lock can be passed to the collector so that multiple asynchronous writebacks won't interfere with each other.

The patches can also be found here:

https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-fixes

Thanks,
David

[1] https://sashiko.dev/#/patchset/20260608145432.681865-1-dhowells%40redhat.com
[2] https://sashiko.dev/#/patchset/20260616100821.2062304-1-dhowells%40redhat.com

Changes
=======
ver #1)
- Added a fix for S_KERNEL_FILE in cachefiles_bury_object().
- Fixed how iov_iter_extract_*_pages() deals with *pages when returning 0 or error.
- Fixed the replacement of wb_lock with bit lock:
- Only release the bit lock for writeback, writethrough and write-single, not for PG_private_2-based I/O, which doesn't take the lock.
- In netfs_writeback_single(), need to redirty the inode if can't get the lock.

David Howells (11):
netfs: Fix decision whether to disallow write-streaming due to fscache
use
cachefiles: Fix double fput
cachefiles: Fix file burial to take lock when unsetting S_KERNEL_FILE
iov_iter: Fix potential underflow in iov_iter_extract_xarray_pages()
iov_iter: Fix missing alloc fail check in
iov_iter_extract_bvec_pages()
iov_iter: Fix a memory leak in iov_iter_extract_user_pages()
iov_iter: Remove unused variable in kunit_iov_iter.c
scatterlist: Fix offset in folio calc in extract_xarray_to_sg()
netfs: Fix kdoc warning
netfs: Replace wb_lock with a bit lock for asynchronicity
netfs: Fix writethrough to use collection offload

 fs/afs/symlink.c           |  4 +-
 fs/cachefiles/namei.c      |  3 +-
 fs/netfs/buffered_write.c  |  2 +-
 fs/netfs/internal.h        | 12 +++++
 fs/netfs/locking.c         | 95 ++++++++++++++++++++++++++++++++++++++
 fs/netfs/write_collect.c   | 10 ++++
 fs/netfs/write_issue.c     | 38 +++++----------
 include/linux/netfs.h      | 13 ++++--
 lib/iov_iter.c             | 20 +++++++-
 lib/scatterlist.c          |  1 +
 lib/tests/kunit_iov_iter.c |  5 +-
 11 files changed, 164 insertions(+), 39 deletions(-)