Skip to content

tracing: Move trace_printk.h out of kernel.h

Steven Rostedt dri-devel intel-gfx kvm linux-arm-kernel linux-doc linux-ext4 linux-kbuild linux-nfs linux-rdma linux-trace-kernel linux-usb linuxppc-dev lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tracing: Move non-trace_printk prototypes back to kernel.hinclude/linux/kernel.h include/linux/trace_printk.h+18 -172 replies
2/2tracing: Add CONFIG_TRACE_PRINTK_DEBUGGING to clean up kernel.hDocumentation/process/debugging/driver_development_debugging_guide.rst Makefile arch/powerpc/kvm/book3s_xics.c +18 more+38 -77 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] tracing: Move trace_printk.h out of kernel.h

There's been complaints about trace_printk() being defined in kernel.h as it can increase the compilation time. As it is only used by some developers for debugging purposes, it should not be in kernel.h causing lots of wasted CPU cycles for those that do not ever care about it.

Instead, add a CONFIG_TRACE_PRINTK_DEBUGGING option that developers that do use it can set and not have to always remember to add #include <linux/trace_printk.h> to the files they add trace_printk() while debugging. It also means that those that do not have that config set will not have to worry about wasted CPU cycles as it is only include in the CFLAGS when the option is set, and its completely ignored otherwise.

Steven Rostedt (2):
tracing: Move non-trace_printk prototypes back to kernel.h
tracing: Add CONFIG_TRACE_PRINTK_DEBUGGING to clean up kernel.h

----

 .../driver_development_debugging_guide.rst         |  2 +-
 Makefile                                           |  5 +++++
 arch/powerpc/kvm/book3s_xics.c                     |  1 +
 drivers/gpu/drm/i915/gt/intel_gtt.h                |  1 +
 drivers/gpu/drm/i915/i915_gem.h                    |  1 +
 drivers/hwtracing/stm/dummy_stm.c                  |  4 ++++
 drivers/infiniband/hw/hfi1/trace_dbg.h             |  1 +
 drivers/usb/early/xhci-dbc.c                       |  1 +
 fs/ext4/inline.c                                   |  1 +
 include/linux/kernel.h                             | 19 ++++++++++++++++++-
 include/linux/sunrpc/debug.h                       |  1 +
 include/linux/trace_printk.h                       | 22 +++-------------------
 kernel/trace/Kconfig                               | 10 ++++++++++
 kernel/trace/ring_buffer_benchmark.c               |  1 +
 kernel/trace/trace.h                               |  1 +
 samples/fprobe/fprobe_example.c                    |  1 +
 samples/ftrace/ftrace-direct-modify.c              |  1 +
 samples/ftrace/ftrace-direct-multi-modify.c        |  1 +
 samples/ftrace/ftrace-direct-multi.c               |  2 +-
 samples/ftrace/ftrace-direct-too.c                 |  2 +-
 samples/ftrace/ftrace-direct.c                     |  2 +-
 21 files changed, 56 insertions(+), 24 deletions(-)