Skip to content

net/mlx5e: Report zero bandwidth for non-ETS traffic

Tariq Toukan linux-rdma lkml netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesApplied 2/2
  2. v13 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- Dropped patch 2 "net/mlx5e: Validate bandwidth for non-ETS traffic classes" (Jakub). We'll submit a more generic version of it.

Patches in v2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2net/mlx5e: Report zero bandwidth for non-ETS traffic classesdrivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c+7 -00 repliesApplied
2/2net/mlx5e: Reject unsupported CB Shaper TSA in ETS validationdrivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c+8 -00 repliesApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchCarolina JubranPavan Chebbi
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net V2 0/2] net/mlx5e: Report zero bandwidth for non-ETS traffic

Hi,

The IEEE 802.1Qaz standard restricts bandwidth allocation percentages to Enhanced Transmission Selection (ETS) traffic classes; STRICT, VENDOR, and CB Shaper TSA types carry no bandwidth semantics. Two problems exist in the mlx5e DCBNL ETS implementation: the get path reports 100% bandwidth for all TCs regardless of TSA type due to a hardware limitation, introduced by commit 820c2c5e773d ("net/mlx5e:
Read ETS settings directly from firmware"), and the set path does not reject the unsupported CB Shaper TSA, introduced by commit 08fb1dacdd76 ("net/mlx5e: Support DCBNL IEEE ETS").

This series by Alexei Lazar fixes the get path to report zero bandwidth for non-ETS traffic classes, and rejects CB Shaper TSA configurations that the driver does not support.

Regards,
Tariq

V2:
- Dropped patch 2 "net/mlx5e: Validate bandwidth for non-ETS traffic classes" (Jakub). We'll submit a more generic version of it.

V1:
https://lore.kernel.org/all/[email protected]/

Alexei Lazar (2):
net/mlx5e: Report zero bandwidth for non-ETS traffic classes net/mlx5e: Reject unsupported CB Shaper TSA in ETS validation

 .../net/ethernet/mellanox/mlx5/core/en_dcbnl.c    | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

base-commit: 3f1f755366687d051174739fb99f7d560202f60b

Signature · 1 line
2.44.0