Skip to content

ocfs2: validate xattr entry bounds

Cen Zhang lkml ocfs2-devel 4 versions – Applied

Status from this message: [merged mm-nonmm-stable] ocfs2-validate-external-xattr-entries-when-reading-metadata.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest2 patches 2 repliesApplied 2/2
  2. v62 patches 1 replySuperseded
  3. v52 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v42 patches2 repliesSuperseded

Patches in v7 All 2 applied

#Subject and filesSizeRepliesApplied
1/2ocfs2: validate inline xattrs during inode block validationfs/ocfs2/inode.c fs/ocfs2/xattr.c fs/ocfs2/xattr.h+111 -131 replyApplied
2/2ocfs2: validate external xattr entries when reading metadatafs/ocfs2/xattr.c+97 -01 replyApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJoseph Qi
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/2] ocfs2: validate xattr entry bounds

Hi,

This series validates OCFS2 xattr entry name/value bounds when xattr metadata is read and validated, before getxattr() or listxattr() can walk out-of-range entry arrays or offsets from corrupted metadata.

Patch 1 validates inline xattrs from ocfs2_validate_inode_block(). Patch 2 validates non-indexed xattr blocks from ocfs2_validate_xattr_block() and indexed xattr buckets after bucket ECC validation.

Cen Zhang (2):
ocfs2: validate inline xattrs during inode block validation
ocfs2: validate external xattr entries when reading metadata

 fs/ocfs2/inode.c |   4 +
 fs/ocfs2/xattr.c | 215 ++++++++++++++++++++++++++++++++++++++++++++---
 fs/ocfs2/xattr.h |   2 +
 3 files changed, 208 insertions(+), 13 deletions(-)
Signature · 1 line
2.43.0