Skip to content

s390x: Fix intermittent errors with IPL from PCI devices on s390x

[email protected] qemu-devel 2 versions – Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 8 repliesApplied
  2. v15 patches 9 repliesSuperseded

Changes in v2 from the cover letter

- Split addition of missing break into its own patch
- Add PCI case to generic is_viritio_supported() wapper
- Switch the order of patches formerly 3 and 4
- Use virtio_is_supported() instead of checking cutype when writing IPLB location to cover both CCW and PCI virtio devices

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6pc-bios/s390-ccw: Refactor byte swappingpc-bios/s390-ccw/virtio.c+12 -120 replies
2/6pc-bios/s390-ccw/virtio.c: Fix missing break for PCI notificationspc-bios/s390-ccw/virtio.c+1 -02 replies
3/6pc-bios/s390-ccw: Add per-queue notification offset for multi-queue virtio configurationspc-bios/s390-ccw/virtio-pci.c pc-bios/s390-ccw/virtio-pci.h pc-bios/s390-ccw/virtio.c +1 more+26 -171 reply
4/6pc-bios/s390-ccw: Verify virtio support when booting from virtio PCI device on s390xpc-bios/s390-ccw/main.c pc-bios/s390-ccw/virtio-pci.c pc-bios/s390-ccw/virtio-pci.h +2 more+26 -01 reply
5/6pc-bios/s390-ccw: write IPLB location for non-net virtio devicespc-bios/s390-ccw/main.c+2 -11 reply
6/6s390x: Enable boot menu for virtio pci devicehw/s390x/ipl.c pc-bios/s390-ccw/main.c+2 -01 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchEric FarmanMatthew Rosato
SeriesT-b
1/6R-b
2/6R-b R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] s390x: Fix intermittent errors with IPL from PCI devices on s390x

From: Jared Rossi <[email protected]>

When booting from a PCI device on s390x there may be intermittent failures caused by mismatched byte swaps. Refactor the byte swapping to ensure that it is properly synchronized.

Correct how the queue notification offset is calculated so that it may be used for multi-queue configurations in the future.

Handle some switch cases that were not caught for PCI devices.

Changes v1 -> v2:
- Split addition of missing break into its own patch
- Add PCI case to generic is_viritio_supported() wapper
- Switch the order of patches formerly 3 and 4
- Use virtio_is_supported() instead of checking cutype when writing IPLB location to cover both CCW and PCI virtio devices

Jared Rossi (3):
pc-bios/s390-ccw/virtio.c: Fix missing break for PCI notifications pc-bios/s390-ccw: Verify virtio support when booting from virtio PCI

    device on s390x

pc-bios/s390-ccw: write IPLB location for non-net virtio devices

Zhuoying Cai (3):
pc-bios/s390-ccw: Refactor byte swapping pc-bios/s390-ccw: Add per-queue notification offset for multi-queue
virtio configurations
s390x: Enable boot menu for virtio pci device

 hw/s390x/ipl.c                |  1 +
 pc-bios/s390-ccw/main.c       |  5 ++-
 pc-bios/s390-ccw/virtio-pci.c | 57 ++++++++++++++++++++++++++---------
 pc-bios/s390-ccw/virtio-pci.h |  5 ++-
 pc-bios/s390-ccw/virtio.c     | 29 ++++++++++--------
 pc-bios/s390-ccw/virtio.h     |  2 ++
 6 files changed, 69 insertions(+), 30 deletions(-)
Signature · 1 line
2.54.0