ibmvfc: Add NVMe-FC support
Status from this message: Applied to 7.3/scsi-staging, thanks!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/29 | ibmvfc: move target list from host to protocol specific channel groupsdrivers/ drivers/ | +28 | 0 replies | |
| 2/29 | ibmvfc: add NVMe/FC protocol interface definitionsdrivers/ | +119 | 0 replies | |
| 3/29 | ibmvfc: split NVMe support into separate source file and add transport stubsdrivers/ drivers/ drivers/ +2 more | +146 | 0 replies | |
| 4/29 | ibmvfc: initialize NVMe channel configuration during driver probedrivers/ drivers/ | +8 | 0 replies | |
| 5/29 | ibmvfc: alloc/dealloc sub-queues for nvme channelsdrivers/ | +14 | 0 replies | |
| 6/29 | ibmvfc: add logic for protocol specific fabric loginsdrivers/ drivers/ | +206 | 0 replies | |
| 7/29 | ibmvfc: add wrapper to get vhost associated with a channel structdrivers/ | +10 | 0 replies | |
| 8/29 | ibmvfc: add helper for creating protocol specific discovery eventdrivers/ | +27 | 0 replies | |
| 9/29 | ibmvfc: add helper to check NVMe/FC support with active channelsdrivers/ | +6 | 0 replies | |
| 10/29 | ibmvfc: allocate and free NVMe channel group discover bufferdrivers/ | +7 | 0 replies | |
| 11/29 | ibmvfc: send NVMe target discovery MADdrivers/ | +43 | 0 replies | |
| 12/29 | ibmvfc: add NVMe/FC Implicit Logout and Move Login supportdrivers/ | +22 | 0 replies | |
| 13/29 | ibmvfc: add NVMe/FC Port Login supportdrivers/ | +9 | 0 replies | |
| 14/29 | ibmvfc: add NVMe/FC Process Login supportdrivers/ drivers/ | +45 | 0 replies | |
| 15/29 | ibmvfc: add NVMe/FC Query Target supportdrivers/ | +9 | 0 replies | |
| 16/29 | ibmvfc: allocate targets based on protocoldrivers/ | +17 | 0 replies | |
| 17/29 | ibmvfc: delete NVMe/FC targets as well as SCSIdrivers/ | +10 | 0 replies | |
| 18/29 | ibmvfc: update state machine to process NVMe/FC targetsdrivers/ | +42 | 0 replies | |
| 19/29 | ibmvfc: implement NVMe/FC stubs for local/remote port registrationdrivers/ drivers/ drivers/ | +83 | 0 replies | |
| 20/29 | ibmvfc: register local nvme fc port after fabric logindrivers/ drivers/ | +18 | 0 replies | |
| 21/29 | ibmvfc: process NVMe/FC rports in work threaddrivers/ | +67 | 0 replies | |
| 22/29 | ibmvfc: extend ibmvfc_debug visibility to ibmvfc-nvme.hdrivers/ drivers/ | +4 | 0 replies | |
| 23/29 | ibmvfc: declare global function definitionsdrivers/ drivers/ | +23 | 0 replies | |
| 24/29 | ibmvfc: implement LLDD callbacks for mapping nvme-fc queuesdrivers/ drivers/ | +43 | 0 replies | |
| 25/29 | ibmvfc: implement nvme-fc LS submission transport callbackdrivers/ drivers/ drivers/ | +99 | 0 replies | |
| 26/29 | ibmvfc: implement nvme-fc IO command submission callbackdrivers/ drivers/ drivers/ | +141 | 0 replies | |
| 27/29 | ibmvfc: implement nvme-fc LS abort handling callbackdrivers/ | +64 | 0 replies | |
| 28/29 | ibmvfc: implement nvme-fc FCP abort callbackdrivers/ | +64 | 0 replies | |
| 29/29 | ibmvfc: fail nvme-fc fcp-io and ls requests during transport resetdrivers/ | +21 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/29] ibmvfc: Add NVMe-FC support
This patch series adds NVMe-FC protocol support to the ibmvfc driver, enabling IBM POWER virtual Fibre Channel adapters to handle both SCSI and NVMe storage traffic through a unified driver architecture.
The implementation leverages the existing multi-queue infrastructure and extends the driver's protocol handling to support NVMe-FC alongside traditional SCSI FCP. Key architectural changes include:
- Refactoring the driver into protocol-agnostic core (ibmvfc-core.c) and protocol-specific modules (ibmvfc-nvme.c for NVMe-FC)
- Extending the target discovery and management state machine to handle NVMe/FC targets with appropriate protocol-specific login sequences
- Implementing the nvme-fc LLDD (Low-Level Device Driver) callbacks for queue management, command submission, and abort handling
- Adding support for NVMe-FC specific MAD (Management Adapter Data) operations including target discovery, port login, process login, and implicit logout/move login
- Implementing NVMe FCP and Link Services (LS) command submission and abort paths using the existing sub-CRQ infrastructure
The series is organized to introduce changes incrementally:
Patches 1-8: Infrastructure and refactoring
- Move target lists to protocol-specific channel groups
- Split NVMe support into separate source file
- Add protocol interface definitions and helper functions
- Initialize NVMe channel configuration
Patches 9-16: NVMe/FC MAD operations and target management
- Implement discovery, port login, process login, query target
- Add target allocation based on protocol
- Update state machine for NVMe/FC target processing
- Handle NVMe/FC target deletion
Patches 17-20: Local and remote port registration
- Implement nvme-fc local port registration after fabric login
- Process NVMe/FC rports in work thread
- Extend debug visibility for NVMe components
Patches 21-26: LLDD callback implementation
- Implement queue mapping callbacks
- Add LS and FCP command submission paths
- Implement NVMe FCP and LS abort handling
Patches 27-29: Error handling and debugging
- Fail NVMe requests during transport reset
Tyrel Datwyler (29):
ibmvfc: move target list from host to protocol specific channel groups
ibmvfc: add NVMe/FC protocol interface definitions
ibmvfc: split NVMe support into separate source file and add transport
stubs
ibmvfc: initialize NVMe channel configuration during driver probe
ibmvfc: alloc/dealloc sub-queues for nvme channels
ibmvfc: add logic for protocol specific fabric logins
ibmvfc: add wrapper to get vhost associated with a channel struct
ibmvfc: add helper for creating protocol specific discovery event
ibmvfc: add helper to check NVMe/FC support with active channels
ibmvfc: allocate and free NVMe channel group discover buffer
ibmvfc: send NVMe target discovery MAD
ibmvfc: add NVMe/FC Implicit Logout and Move Login support
ibmvfc: add NVMe/FC Port Login support
ibmvfc: add NVMe/FC Process Login support
ibmvfc: add NVMe/FC Query Target support
ibmvfc: allocate targets based on protocol
ibmvfc: delete NVMe/FC targets as well as SCSI
ibmvfc: update state machine to process NVMe/FC targets
ibmvfc: implement NVMe/FC stubs for local/remote port registration
ibmvfc: register local nvme fc port after fabric login
ibmvfc: process NVMe/FC rports in work thread
ibmvfc: extend ibmvfc_debug visibility to ibmvfc-nvme.h
ibmvfc: declare global function definitions
ibmvfc: implement LLDD callbacks for mapping nvme-fc queues
ibmvfc: implement nvme-fc LS submission transport callback
ibmvfc: implement nvme-fc IO command submission callback
ibmvfc: implement nvme-fc LS abort handling callback
ibmvfc: implement nvme-fc FCP abort callback
ibmvfc: fail nvme-fc fcp-io and ls requests during transport reset
drivers/scsi/ibmvscsi/Makefile | 2 +
.../scsi/ibmvscsi/{ibmvfc.c => ibmvfc-core.c} | 709 ++++++++++++++----
drivers/scsi/ibmvscsi/ibmvfc-nvme.c | 565 ++++++++++++++
drivers/scsi/ibmvscsi/ibmvfc-nvme.h | 48 ++
drivers/scsi/ibmvscsi/ibmvfc.h | 209 +++++-
5 files changed, 1360 insertions(+), 173 deletions(-)
rename drivers/scsi/ibmvscsi/{ibmvfc.c => ibmvfc-core.c} (89%)
create mode 100644 drivers/scsi/ibmvscsi/ibmvfc-nvme.c
create mode 100644 drivers/scsi/ibmvscsi/ibmvfc-nvme.hSignature · 1 line
2.54.0