Skip to content

ibmvfc: Add NVMe-FC support

Tyrel Datwyler linux-scsi linuxppc-dev lkml 1 version Applied

Status from this message: Applied to 7.3/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest29 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/29ibmvfc: move target list from host to protocol specific channel groupsdrivers/scsi/ibmvscsi/ibmvfc.c drivers/scsi/ibmvscsi/ibmvfc.h+28 -280 replies
2/29ibmvfc: add NVMe/FC protocol interface definitionsdrivers/scsi/ibmvscsi/ibmvfc.h+119 -340 replies
3/29ibmvfc: split NVMe support into separate source file and add transport stubsdrivers/scsi/ibmvscsi/Makefile drivers/scsi/ibmvscsi/ibmvfc-core.c drivers/scsi/ibmvscsi/ibmvfc-nvme.c +2 more+146 -40 replies
4/29ibmvfc: initialize NVMe channel configuration during driver probedrivers/scsi/ibmvscsi/ibmvfc-core.c drivers/scsi/ibmvscsi/ibmvfc.h+8 -10 replies
5/29ibmvfc: alloc/dealloc sub-queues for nvme channelsdrivers/scsi/ibmvscsi/ibmvfc-core.c+14 -10 replies
6/29ibmvfc: add logic for protocol specific fabric loginsdrivers/scsi/ibmvscsi/ibmvfc-core.c drivers/scsi/ibmvscsi/ibmvfc.h+206 -350 replies
7/29ibmvfc: add wrapper to get vhost associated with a channel structdrivers/scsi/ibmvscsi/ibmvfc.h+10 -00 replies
8/29ibmvfc: add helper for creating protocol specific discovery eventdrivers/scsi/ibmvscsi/ibmvfc-core.c+27 -120 replies
9/29ibmvfc: add helper to check NVMe/FC support with active channelsdrivers/scsi/ibmvscsi/ibmvfc-core.c+6 -00 replies
10/29ibmvfc: allocate and free NVMe channel group discover bufferdrivers/scsi/ibmvscsi/ibmvfc-core.c+7 -10 replies
11/29ibmvfc: send NVMe target discovery MADdrivers/scsi/ibmvscsi/ibmvfc-core.c+43 -70 replies
12/29ibmvfc: add NVMe/FC Implicit Logout and Move Login supportdrivers/scsi/ibmvscsi/ibmvfc-core.c+22 -110 replies
13/29ibmvfc: add NVMe/FC Port Login supportdrivers/scsi/ibmvscsi/ibmvfc-core.c+9 -60 replies
14/29ibmvfc: add NVMe/FC Process Login supportdrivers/scsi/ibmvscsi/ibmvfc-core.c drivers/scsi/ibmvscsi/ibmvfc.h+45 -160 replies
15/29ibmvfc: add NVMe/FC Query Target supportdrivers/scsi/ibmvscsi/ibmvfc-core.c+9 -60 replies
16/29ibmvfc: allocate targets based on protocoldrivers/scsi/ibmvscsi/ibmvfc-core.c+17 -50 replies
17/29ibmvfc: delete NVMe/FC targets as well as SCSIdrivers/scsi/ibmvscsi/ibmvfc-core.c+10 -20 replies
18/29ibmvfc: update state machine to process NVMe/FC targetsdrivers/scsi/ibmvscsi/ibmvfc-core.c+42 -00 replies
19/29ibmvfc: implement NVMe/FC stubs for local/remote port registrationdrivers/scsi/ibmvscsi/ibmvfc-nvme.c drivers/scsi/ibmvscsi/ibmvfc-nvme.h drivers/scsi/ibmvscsi/ibmvfc.h+83 -40 replies
20/29ibmvfc: register local nvme fc port after fabric logindrivers/scsi/ibmvscsi/ibmvfc-core.c drivers/scsi/ibmvscsi/ibmvfc-nvme.c+18 -30 replies
21/29ibmvfc: process NVMe/FC rports in work threaddrivers/scsi/ibmvscsi/ibmvfc-core.c+67 -10 replies
22/29ibmvfc: extend ibmvfc_debug visibility to ibmvfc-nvme.hdrivers/scsi/ibmvscsi/ibmvfc-core.c drivers/scsi/ibmvscsi/ibmvfc-nvme.h+4 -10 replies
23/29ibmvfc: declare global function definitionsdrivers/scsi/ibmvscsi/ibmvfc-core.c drivers/scsi/ibmvscsi/ibmvfc.h+23 -160 replies
24/29ibmvfc: implement LLDD callbacks for mapping nvme-fc queuesdrivers/scsi/ibmvscsi/ibmvfc-nvme.c drivers/scsi/ibmvscsi/ibmvfc-nvme.h+43 -20 replies
25/29ibmvfc: implement nvme-fc LS submission transport callbackdrivers/scsi/ibmvscsi/ibmvfc-nvme.c drivers/scsi/ibmvscsi/ibmvfc-nvme.h drivers/scsi/ibmvscsi/ibmvfc.h+99 -00 replies
26/29ibmvfc: implement nvme-fc IO command submission callbackdrivers/scsi/ibmvscsi/ibmvfc-core.c drivers/scsi/ibmvscsi/ibmvfc-nvme.c drivers/scsi/ibmvscsi/ibmvfc.h+141 -20 replies
27/29ibmvfc: implement nvme-fc LS abort handling callbackdrivers/scsi/ibmvscsi/ibmvfc-nvme.c+64 -00 replies
28/29ibmvfc: implement nvme-fc FCP abort callbackdrivers/scsi/ibmvscsi/ibmvfc-nvme.c+64 -00 replies
29/29ibmvfc: fail nvme-fc fcp-io and ls requests during transport resetdrivers/scsi/ibmvscsi/ibmvfc-core.c+21 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/29] ibmvfc: Add NVMe-FC support

This patch series adds NVMe-FC protocol support to the ibmvfc driver, enabling IBM POWER virtual Fibre Channel adapters to handle both SCSI and NVMe storage traffic through a unified driver architecture.

The implementation leverages the existing multi-queue infrastructure and extends the driver's protocol handling to support NVMe-FC alongside traditional SCSI FCP. Key architectural changes include:

- Refactoring the driver into protocol-agnostic core (ibmvfc-core.c) and protocol-specific modules (ibmvfc-nvme.c for NVMe-FC)
- Extending the target discovery and management state machine to handle NVMe/FC targets with appropriate protocol-specific login sequences
- Implementing the nvme-fc LLDD (Low-Level Device Driver) callbacks for queue management, command submission, and abort handling
- Adding support for NVMe-FC specific MAD (Management Adapter Data) operations including target discovery, port login, process login, and implicit logout/move login
- Implementing NVMe FCP and Link Services (LS) command submission and abort paths using the existing sub-CRQ infrastructure

The series is organized to introduce changes incrementally:

Patches 1-8: Infrastructure and refactoring
- Move target lists to protocol-specific channel groups
- Split NVMe support into separate source file
- Add protocol interface definitions and helper functions
- Initialize NVMe channel configuration

Patches 9-16: NVMe/FC MAD operations and target management
- Implement discovery, port login, process login, query target
- Add target allocation based on protocol
- Update state machine for NVMe/FC target processing
- Handle NVMe/FC target deletion

Patches 17-20: Local and remote port registration
- Implement nvme-fc local port registration after fabric login
- Process NVMe/FC rports in work thread
- Extend debug visibility for NVMe components

Patches 21-26: LLDD callback implementation
- Implement queue mapping callbacks
- Add LS and FCP command submission paths
- Implement NVMe FCP and LS abort handling

Patches 27-29: Error handling and debugging
- Fail NVMe requests during transport reset

Tyrel Datwyler (29):
ibmvfc: move target list from host to protocol specific channel groups
ibmvfc: add NVMe/FC protocol interface definitions
ibmvfc: split NVMe support into separate source file and add transport
stubs
ibmvfc: initialize NVMe channel configuration during driver probe
ibmvfc: alloc/dealloc sub-queues for nvme channels
ibmvfc: add logic for protocol specific fabric logins
ibmvfc: add wrapper to get vhost associated with a channel struct
ibmvfc: add helper for creating protocol specific discovery event
ibmvfc: add helper to check NVMe/FC support with active channels
ibmvfc: allocate and free NVMe channel group discover buffer
ibmvfc: send NVMe target discovery MAD
ibmvfc: add NVMe/FC Implicit Logout and Move Login support
ibmvfc: add NVMe/FC Port Login support
ibmvfc: add NVMe/FC Process Login support
ibmvfc: add NVMe/FC Query Target support
ibmvfc: allocate targets based on protocol
ibmvfc: delete NVMe/FC targets as well as SCSI
ibmvfc: update state machine to process NVMe/FC targets
ibmvfc: implement NVMe/FC stubs for local/remote port registration
ibmvfc: register local nvme fc port after fabric login
ibmvfc: process NVMe/FC rports in work thread
ibmvfc: extend ibmvfc_debug visibility to ibmvfc-nvme.h
ibmvfc: declare global function definitions
ibmvfc: implement LLDD callbacks for mapping nvme-fc queues
ibmvfc: implement nvme-fc LS submission transport callback
ibmvfc: implement nvme-fc IO command submission callback
ibmvfc: implement nvme-fc LS abort handling callback
ibmvfc: implement nvme-fc FCP abort callback
ibmvfc: fail nvme-fc fcp-io and ls requests during transport reset

 drivers/scsi/ibmvscsi/Makefile                |   2 +
 .../scsi/ibmvscsi/{ibmvfc.c => ibmvfc-core.c} | 709 ++++++++++++++----
 drivers/scsi/ibmvscsi/ibmvfc-nvme.c           | 565 ++++++++++++++
 drivers/scsi/ibmvscsi/ibmvfc-nvme.h           |  48 ++
 drivers/scsi/ibmvscsi/ibmvfc.h                | 209 +++++-
 5 files changed, 1360 insertions(+), 173 deletions(-)
 rename drivers/scsi/ibmvscsi/{ibmvfc.c => ibmvfc-core.c} (89%)
 create mode 100644 drivers/scsi/ibmvscsi/ibmvfc-nvme.c
 create mode 100644 drivers/scsi/ibmvscsi/ibmvfc-nvme.h
Signature · 1 line
2.54.0