Skip to content

smb: fix fallocate and allocation accounting

Huiwen He linux-cifs 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest5 patches 3 repliesIn review
  2. v74 patches 0 repliesSuperseded
  3. v65 patches 7 repliesApplied
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v54 patches0 repliesSuperseded
v47 patches4 repliesSuperseded
v39 patches0 repliesSuperseded
v29 patches4 repliesApplied
v17 patches1 replySuperseded

Changes in v8 from the cover letter

- Add back the overlapping allocated-range fix as patch 2. This patch was dropped after v5, but it addresses Shashiko's review comments about overlapping allocated ranges and malformed range lengths.

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5smb/client: refresh allocation size after duplicate extentsfs/smb/client/cifsfs.c fs/smb/client/smb2ops.c+37 -30 replies
2/5smb/client: handle overlapping allocated ranges in fallocatefs/smb/client/smb2ops.c+18 -70 replies
3/5smb/client: reduce fallocate zero buffer allocationfs/smb/client/smb2ops.c+4 -30 replies
4/5smb/client: emulate small EOF-extending mode 0 fallocate rangesfs/smb/client/smb2ops.c+60 -90 replies
5/5smb/client: refresh allocation after EOF-extending fallocatefs/smb/client/smb2ops.c fs/smb/client/smb2pdu.c fs/smb/client/smb2proto.h +2 more+67 -73 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchChenXiaoSong
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 0/5] smb: fix fallocate and allocation accounting

From: Huiwen He <[email protected]>

Changes in v8:

- Add back the overlapping allocated-range fix as patch 2. This patch was dropped after v5, but it addresses Shashiko's review comments about overlapping allocated ranges and malformed range lengths.

Although I could not reproduce this locally, a malicious or unusualserver could theoretically return such a range.

- Rebase the later patches on top of the restored patch 2. No other behavior change is intended.

The following patch merged into #ksmbd-for-next-next is not resent:
- smb/server: map SET_INFO ENOSPC to disk full

The following patches are already in upstream and are not resent:
- 898d280f4e4d smb/client: name the default fallocate mode
- 2a4b3d2db5c6 smb/client: preserve errors from smb2_set_sparse()
- 99cd0a6eeb6c smb/client: do not account EOF extension as allocation

Link to v7:
https://lore.kernel.org/linux-cifs/[email protected]

Thanks,
Huiwen

Huiwen He (5):
smb/client: refresh allocation size after duplicate extents smb/client: handle overlapping allocated ranges in fallocate smb/client: reduce fallocate zero buffer allocation smb/client: emulate small EOF-extending mode 0 fallocate ranges smb/client: refresh allocation after EOF-extending fallocate

 fs/smb/client/cifsfs.c    |  10 ++-
 fs/smb/client/smb2ops.c   | 172 +++++++++++++++++++++++++++++++++-----
 fs/smb/client/smb2pdu.c   |  19 +++++
 fs/smb/client/smb2proto.h |   3 +
 fs/smb/common/fscc.h      |   5 ++
 fs/smb/server/smb2pdu.h   |   4 -
 6 files changed, 185 insertions(+), 28 deletions(-)
Signature · 1 line
2.43.0