Skip to content

add versioned symbols for recently stabilized APIs

Dariusz Sosnowski dpdk-dev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 3 repliesIn review
  2. v34 patches 2 repliesSuperseded
  3. v24 patches 7 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches6 repliesSuperseded

Changes in v4 from the cover letter

- Fixed build with older meson versions.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4eal: fix macro for versioned experimental symbollib/eal/common/eal_export.h+1 -10 replies
2/4build: support function versioning for driversdrivers/meson.build+20 -10 replies
3/4net/mlx5: fix stabilized function versionsdrivers/net/mlx5/meson.build drivers/net/mlx5/mlx5_driver_event.c drivers/net/mlx5/mlx5_flow.c+30 -120 replies
4/4ethdev: fix promoted flow metadata symbolslib/ethdev/meson.build lib/ethdev/rte_flow.c+10 -50 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchDavid Marchand
1/4R-b
2/4
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] add versioned symbols for recently stabilized APIs

Main goal of this patchset is to address https://bugs.dpdk.org/show_bug.cgi?id=1957
but it also handles other recently stabilized symbols and has some minor fixes:

- Patch 1 - Fix RTE_VERSION_EXPERIMENTAL_SYMBOL macro on clang.
- Patch 2 - Allow function versioning inside drivers.
- Patch 3 - Version the function symbols stabilized in
https://git.dpdk.org/dpdk/commit/?id=e8cab133645f5466ef75e511629add43b68a5027
- Patch 4 - Version the rte_flow_dynf_metadata_register() function stabilized in
https://git.dpdk.org/dpdk/commit/?id=4ee2f5c1cedf9ee7f39afa667f71b07f4004ba5c
Restore EXPERIMENTAL version on global variable symbols rte_flow_dynf_metadata_offs and rte_flow_dynf_metadata_mask.

v4:
- Fixed build with older meson versions.

v3:
- https://inbox.dpdk.org/dev/[email protected]/
- Added rebuilding of drivers with -DRTE_BUILD_SHARED_LIB whenever function versioning is enabled.

v2:
- https://inbox.dpdk.org/dev/[email protected]/
- Drop patches introducing versioning macros for symbol aliases and their usage (patch 4 and 5 from v1)
- EXPERIMENTAL version on global variable symbols rte_flow_dynf_metadata_offs and rte_flow_dynf_metadata_mask, as discussed under v1.
- Change commit title prefix in patch (2) from "drivers" to "build".

v1: https://inbox.dpdk.org/dev/[email protected]/

Dariusz Sosnowski (4):
eal: fix macro for versioned experimental symbol
build: support function versioning for drivers net/mlx5: fix stabilized function versions
ethdev: fix promoted flow metadata symbols

 drivers/meson.build                  | 21 ++++++++++++++++++++-
 drivers/net/mlx5/meson.build         |  2 ++
 drivers/net/mlx5/mlx5_driver_event.c | 22 ++++++++++++++++------
 drivers/net/mlx5/mlx5_flow.c         | 18 ++++++++++++------
 lib/eal/common/eal_export.h          |  2 +-
 lib/ethdev/meson.build               |  2 ++
 lib/ethdev/rte_flow.c                | 13 ++++++++-----
 7 files changed, 61 insertions(+), 19 deletions(-)

--
2.47.3