Skip to content

iomap/fuse: add helper to keep uptodate bitmap in sync

Joanne Koong fuse-devel linux-fsdevel 3 versions – Applied

Status from this message: Applied to the vfs-7.3.iomap branch of the vfs/vfs.git tree.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 7 repliesApplied
  2. v22 patches 7 repliesSuperseded
  3. v12 patches 3 repliesSuperseded

v1 -> v2 from the cover letter

* drop helper for clearing uptodate state, as per Matthew and Christoph's comments

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3fuse: don't clear folio uptodate on writethrough errorsfs/fuse/file.c+1 -172 replies
2/3iomap: add helper to mark folio uptodatefs/iomap/buffered-io.c include/linux/iomap.h+7 -02 replies
3/3fuse: use iomap helper to mark folio uptodatefs/fuse/file.c fs/fuse/notify.c+4 -22 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchDarrick J. WongChristoph HellwigMiklos Szeredi
1/3R-b R-b A-b
2/3R-b R-b
3/3R-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/3] iomap/fuse: add helper to keep uptodate bitmap in sync

Filesystems that use iomap normally mark folios uptodate through the iomap read/write paths, which keep iomap's internal uptodate bitmap in sync. However, some filesystems need to write data directly into the page cache outside of those paths (eg fuse, which may need to write server-pushed data straight into the page cache for servicing notify stores). These filesystems need a way to mark a folio uptodate that also updates the iomap bitmap so they're kept in sync.

This series adds iomap_folio_mark_uptodate() for filesystems to do that and updates the relevant fuse call paths to use this. This is needed before fuse can enable large folios.

Patch 1 ("fuse: don't clear folio uptodate on writethrough errors") was originally submitted to the fuse tree [1] but patch 3 ("fuse: use iomap helper to mark folio uptodate") has a dependency on it, so to make cross-coordination between trees easier, patch 1 is now part of this series and submitted to the vfs tree. This series is based on top of the vfs-7.3.iomap branch (head commit e1b77fb85836e ("Merge patch series "iomap: add simple dio path...")).

Thanks,
Joanne

[1] https://lore.kernel.org/fuse-devel/[email protected]/

Changelog
---------
v2: https://lore.kernel.org/linux-fsdevel/[email protected]/
* add Reviewed-by tags and rebase onto the vfs-7.3.iomap branch
* include patch 1 from [1], to ensure ordering between patches for bisectability

v1: https://lore.kernel.org/linux-fsdevel/[email protected]/
v1 -> v2:
* drop helper for clearing uptodate state, as per Matthew and Christoph's comments

Joanne Koong (3):
fuse: don't clear folio uptodate on writethrough errors
iomap: add helper to mark folio uptodate
fuse: use iomap helper to mark folio uptodate

 fs/fuse/file.c         | 20 ++------------------
 fs/fuse/notify.c       |  4 +++-
 fs/iomap/buffered-io.c |  6 ++++++
 include/linux/iomap.h  |  1 +
 4 files changed, 12 insertions(+), 19 deletions(-)
Signature · 1 line
2.52.0