Skip to content

hw/audio/virtio-sound: basic migration support

Alexander Mikhalitsyn qemu-devel 5 versions – Applied

Status from this message: Merged to master

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest10 patches 11 repliesApplied
  2. v410 patches 1 replySuperseded
  3. v39 patches 25 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v29 patches13 repliesSuperseded
v19 patches2 repliesSuperseded

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/10hw/audio/virtio-sound: remove channel positions field from VirtIOSoundPCMStreamhw/audio/virtio-snd.c include/hw/audio/virtio-snd.h+0 -40 replies
2/10hw/audio/virtio-sound: drop unused struct VirtIOSoundPCMStream.flushing fieldinclude/hw/audio/virtio-snd.h+0 -10 replies
3/10hw/audio/virtio-sound: remove command and stream mutexeshw/audio/virtio-snd.c include/hw/audio/virtio-snd.h+110 -1390 replies
4/10hw/audio/virtio-sound: allocate an array of streamshw/audio/virtio-snd.c include/hw/audio/virtio-snd.h+22 -130 replies
5/10hw/audio/virtio-sound: free all stream buffers on resethw/audio/virtio-snd.c+10 -00 replies
6/10hw/audio/virtio-sound: split out virtio_snd_pcm_start_stop()hw/audio/virtio-snd.c+38 -200 replies
7/10hw/audio/virtio-sound: add stream state variablehw/audio/virtio-snd.c include/hw/audio/virtio-snd.h+124 -1062 replies
8/10hw/audio/virtio-sound: introduce virtio_snd_pcm_open()hw/audio/virtio-snd.c+32 -260 replies
9/10hw/audio/virtio-sound: introduce virtio_snd_set_active()hw/audio/virtio-snd.c+16 -50 replies
10/10hw/audio/virtio-sound: add missing vmstate fieldshw/audio/virtio-snd.c include/hw/audio/virtio-snd.h+76 -82 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchManos PitsidianakisMarc-André Lureau
1/10R-b R-b
2/10R-b
3/10R-b R-b
4/10R-b
5/10R-b R-b
6/10R-b
7/10R-b
8/10R-b R-b
9/10R-b
10/10R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/10] hw/audio/virtio-sound: basic migration support

From: Alexander Mikhalitsyn <[email protected]>

Dear friends,

This patchset is aimed to support virtio-sound live migration and based on
pre-existing Volker Rümelin's patches from qemu-devel lists [1]. I tried
to ask (https://lore.kernel.org/qemu-devel/[email protected]/)
if Volker is going to continue his work on this, but received no reply so I
just decided to go forward: take his patches, rebase and resend. Of course,
I kept all authorship/tags so I hope that it is fine.

Testing.

I manually validated this with Ubuntu 24.04 Desktop VM and found no issues. Also, it was validated with CI (https://gitlab.com/mihalicyn/qemu/-/pipelines/2626702088).

Original patchset:
https://lore.kernel.org/qemu-devel/[email protected] [1]

Git tree:
https://gitlab.com/mihalicyn/qemu/-/commits/virtio-sound-migration

Changelog for version 5:
- rebased
- added RWB tags

Changelog for version 4:
- addressed review feedback from Marc-André Lureau
- and from Manos Pitsidianakis
*there is a detailed changelog under each commit message*

Changelog for version 3:
- addressed review feedback from Marc-André Lureau:
- drop VirtIOSoundPCMStream's id field (unused)
- resurrected error_report(..) in virtio_snd_pcm_start_stop()
- fixes in "hw/audio/virtio-sound: add stream state variable" [ please, look in commit message for details ]
- added "hw/audio/virtio-sound: remove channel positions field from VirtIOSoundPCMStream"
- fixes in "hw/audio/virtio-sound: add missing vmstate fields" [ details in commit message ]

Changelog for version 2:
- no code changes (only commit messages)
followed suggestions from Daniel P. Berrangé (thanks, Daniel!)
https://lore.kernel.org/qemu-devel/[email protected]/
and added some extra details about what I did with the original patches during rebase (for some of them it was simpler and less error prone to just drop changes and reimplement them by following the idea of the patch, cause base code has changed significantly).

Changelog relative to the original Volker Rümelin's submission:
- rebased:
- "hw/audio/virtio-sound: return correct command response size" was dropped as it was already merged
- "hw/audio/virtio-sound: fix segmentation fault in tx/rx xfer handler" was dropped as it seems to be replaced with another fix
https://github.com/qemu/qemu/commit/731655f87f319fd06f27282c6cafbc2467ac8045
- I had to drop all pre-existing Reviewed-by tags cause it was 2 years since this patchset was sent and reviewed and I did a quite significant code changes during rebase

Kind regards,
Alex

Alexander Mikhalitsyn (2):
hw/audio/virtio-sound: remove channel positions field from
VirtIOSoundPCMStream
hw/audio/virtio-sound: drop unused struct
VirtIOSoundPCMStream.flushing field

Volker Rümelin (8):
hw/audio/virtio-sound: remove command and stream mutexes hw/audio/virtio-sound: allocate an array of streams hw/audio/virtio-sound: free all stream buffers on reset hw/audio/virtio-sound: split out virtio_snd_pcm_start_stop() hw/audio/virtio-sound: add stream state variable hw/audio/virtio-sound: introduce virtio_snd_pcm_open() hw/audio/virtio-sound: introduce virtio_snd_set_active() hw/audio/virtio-sound: add missing vmstate fields

 hw/audio/virtio-snd.c         | 696 ++++++++++++++++++++--------------
 include/hw/audio/virtio-snd.h |  26 +-
 2 files changed, 414 insertions(+), 308 deletions(-)
Signature · 1 line
2.47.3