Skip to content

sys_info: prevent duplicate backtraces

Bradley Morgan linuxppc-dev lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest4 patches 18 repliesIn review

Changes in v3 from the cover letter

- Use sys_info_with_filter() instead of sys_info_without_all_bt() per Petr's suggestion
- Filter applied at __sys_info() level to handle kernel_si_mask correctly
- Added panic.c conversion

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4sys_info: add helper for callers that print some sys_info on their owninclude/linux/sys_info.h lib/sys_info.c+19 -20 replies
2/4watchdog: use sys_info_with_filter() to avoid duplicate backtraceskernel/watchdog.c+8 -40 replies
3/4powerpc/watchdog: use sys_info_with_filter() to avoid duplicate backtracesarch/powerpc/kernel/watchdog.c+8 -41 reply
4/4panic: use sys_info_with_filter() to avoid duplicate backtraceskernel/panic.c+1 -117 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchFeng Tang
1/4
2/4
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] sys_info: prevent duplicate backtraces

Some callers handle SYS_INFO_ALL_BT themselves before calling sys_info(). When they strip that bit, an all_bt-only mask becomes zero and sys_info(0) falls back to kernel_si_mask, potentially duplicating output.

This series adds sys_info_with_filter() to filter specific bits without triggering the kernel_si_mask fallback.

Changes since v2:
- Use sys_info_with_filter() instead of sys_info_without_all_bt() per Petr's suggestion
- Filter applied at __sys_info() level to handle kernel_si_mask correctly
- Added panic.c conversion

Bradley Morgan (4):
sys_info: add helper for callers that print some sys_info on their own
watchdog: use sys_info_with_filter() to avoid duplicate backtraces powerpc/watchdog: use sys_info_with_filter() to avoid duplicate
backtraces
panic: use sys_info_with_filter() to avoid duplicate backtraces

 arch/powerpc/kernel/watchdog.c | 12 ++++++++----
 include/linux/sys_info.h       |  1 +
 kernel/panic.c                 |  2 +-
 kernel/watchdog.c              | 12 ++++++++----
 lib/sys_info.c                 | 20 ++++++++++++++++++--
 5 files changed, 36 insertions(+), 11 deletions(-)
Signature · 1 line
2.53.0