Skip to content

environment: move excludes_file into repo_config_values

Tian Yuchen git 6 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest1 patch 0 repliesNew
  2. v51 patch 0 repliesSuperseded
  3. v41 patch 10 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v31 patch1 replySuperseded
v22 patches8 repliesSuperseded
v12 patches1 replySuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1environment: move excludes_file into repo_config_valuesdir.c environment.c environment.h +1 more+45 -60 replies

Reviews trailers per patch

The patch has no Reviewed-by or Acked-by.

PatchChristian CouderAyush ChandekarOlamide Caleb Bello
SeriesMentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by
1/1Mentored-by Mentored-by Mentored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/1] environment: move excludes_file into repo_config_values

This patch continues the libification effort by migrating the global string variable 'excludes_file' into 'struct repo_config_values'. Since this is a dynamically allocated variable, the migration requires proper heap memory management.

This patch mainly does three things:

- Abstract the XDG fallback lazy-loading logic out of dir.c into a proper getter.

- Move the variables into the struct repo_config_values.

- Introduce the memory destructor 'repo_config_values_clear()'.

Changes since V5:

Drop the defensive check in 'repo_excludes_file()'.

All known test errors that occur *without* defensive checks are intercepted by the 'repo != the_repository' check when checks *are there*, rather than by the '!repo->initialized' check. In other words, the getter actually doesn't need any checks added, because all of its calls are safe. We just need to keep the check and the 'NEEDSWORK' comment *on the destructor* until 'repo_config_values()' eventually supports submodules, at which point we can remove them.

THANKS!

Tian Yuchen (1):
environment: move excludes_file into repo_config_values

 dir.c         |  4 ++--
 environment.c | 33 ++++++++++++++++++++++++++++++---
 environment.h | 13 ++++++++++++-
 repository.c  |  1 +
 4 files changed, 45 insertions(+), 6 deletions(-)
Signature · 1 line
2.43.0