Skip to content

PCI: mediatek-gen3: Add 2-lanes mode support + clock

Christian Marangi linux-arm-kernel linux-devicetree linux-mediatek linux-pci lkml 5 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 19 repliesApplied
  2. v44 patches 5 repliesSuperseded
  3. v34 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches1 replySuperseded
v14 patches1 replySuperseded

Changes in v5 from the cover letter

- Address formal comments from Bjorn
- Drop clk patch (handled in separate series)
- Add reference to clk changes

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/2dt-bindings: PCI: mediatek-gen3: Split Airoha schema and document 2-lanesDocumentation/devicetree/bindings/pci/airoha,en7581-pcie.yaml Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml+249 -720 replies
2/2PCI: mediatek-gen3: Add 2-lanes mode support for Airoha AN7581drivers/pci/controller/pcie-mediatek-gen3.c+89 -175 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchRob Herring (Arm)
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2] PCI: mediatek-gen3: Add 2-lanes mode support + clock

This small series introduce support for 2-lanes mode for Airoha AN7581 SoC. This is needed for correctly functionality of Eagle WiFi Card normally attached to this SoC that require a 2-line PCIe card to correctly work (and give the proper performance)

The first 2 patch address a limitation of the PCIe implementation where the PERSTOUT reset were indirectly asserted and deasserted all at the same time (for all the 3 PCIe card) with PCIe enable and disable.
The 2 patch address this and introduce correct reset to control reset line for the relevant PCIe line.

The last 2 patch add additional logic and support to assert and deassert the PERSTOUT and also apply the required configuration for 2-lanes mode.

2-lanes mode is implemented in DT by adding the required property and by defining the "num-lanes" to 2.

Changes v5:
- Address formal comments from Bjorn
- Drop clk patch (handled in separate series)
- Add reference to clk changes
Changes v4:
- Improve DT split patch (drop unneeded property)
- Handle power_down PERSTOUT
Changes v3:
- Add Ack from Krzysztof
- Improve commit description of PCIe patch
- Use pcie->num_lanes instead of possible uninit variable num_lanes Changes v2:
- Address typo regs -> reg in Documentation
- Address typo lan -> lane in Documentation
- Apply a suggested fix from Airoha for PCIe MUX configuration before PHY init
- Parse secondary reg in probe
- Add missing reset_status handling for inverted bits
- Move SCU to local handling in power_up
- Add check for max num-lanes for EN7581

Christian Marangi (2):
dt-bindings: PCI: mediatek-gen3: Split Airoha schema and document

    2-lanes

PCI: mediatek-gen3: Add 2-lanes mode support for Airoha AN7581

 .../bindings/pci/airoha,en7581-pcie.yaml      | 244 ++++++++++++++++++
 .../bindings/pci/mediatek-pcie-gen3.yaml      |  77 +-----
 drivers/pci/controller/pcie-mediatek-gen3.c   | 106 ++++++--
 3 files changed, 338 insertions(+), 89 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pci/airoha,en7581-pcie.yaml
Signature · 1 line
2.53.0