Skip to content

imx8-isi: Format support enhancements

Guoniu Zhou imx linux-arm-kernel linux-media lkml stable 5 versions – In review

Get series with b4
b4 am [email protected] change-id 20260626-isi-00f05b044ac9

Versions newest first

  1. v5 Latest4 patches 8 repliesIn review
  2. v43 patches 3 repliesSuperseded
  3. v33 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v26 patches14 repliesSuperseded
v15 patches5 repliesSuperseded

Changes in v5 from the cover letter

- Add new patch 1/4: Use BIT_ULL() for 64-bit stream masks to fix potential issues on 32-bit architectures (Sashiko)
- Patch numbering updated: v4 1/3 -> v5 2/4, v4 2/3 -> v5 3/4, v4 3/3 -> v5 4/4
- Link to v4: https://lore.kernel.org/r/[email protected]

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4media: nxp: imx8-isi: Use BIT_ULL() for 64-bit stream masksdrivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c+2 -23 replies
2/4media: nxp: imx8-isi: Implement per-stream reference counting for multiplexed streamsdrivers/media/platform/nxp/imx8-isi/imx8-isi-core.h drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c+67 -232 replies
3/4media: nxp: imx8-isi: Add 16-bit raw Bayer format supportdrivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c+75 -01 reply
4/4media: nxp: imx8-isi: Add additional 32-bit RGB format supportdrivers/media/platform/nxp/imx8-isi/imx8-isi-video.c+51 -02 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchFrank LiLaurent PinchartLoic Poulain
1/4R-b R-b R-b
2/4R-b R-b
3/4R-b R-b R-b
4/4R-b T-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/4] imx8-isi: Format support enhancements

This is a follow-up series to the imx8-isi bug fixes and format support patches [1]. Patches 1/6, 2/6, and 5/6 from v2 have been merged into the maintainer's branch (pinchart/for-next/media/nxp). This series contains the remaining 3 patches rebased on top of the merged changes, plus a new bug fix patch.

Patch 1 fixes BIT() usage on 64-bit stream masks which could cause incorrect results on 32-bit architectures when stream IDs are 32 or greater.

Patch 2 implements per-stream reference counting in the crossbar to properly enable multiple streams from different virtual channels on the same input pad.

Patch 3 adds support for 16-bit raw Bayer formats (SBGGR16, SGBRG16, SGRBG16, SRGGB16) and Y16 (16-bit monochrome).

Patch 4 extends RGB format support by adding BGRA32, RGBA32, BGRX32, RGBX32, and ARGB2101010 formats.

[1] https://lore.kernel.org/r/[email protected]

---
Changes in v5:
- Add new patch 1/4: Use BIT_ULL() for 64-bit stream masks to fix potential issues on 32-bit architectures (Sashiko)
- Patch numbering updated: v4 1/3 -> v5 2/4, v4 2/3 -> v5 3/4, v4 3/3 -> v5 4/4
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- [1/3] Make enable/disable symmetric by checking stream_in_use
- [1/3] Add mxc_isi_crossbar_stream_in_use() helper for both paths
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Rebased on maintainer's branch which already includes v2 patches 1/6, 2/6, and 5/6 (stream ID validation fixes and color map correction)
- Series reduced from 6 patches to 3 patches (remaining unmerged patches)
- Patch numbering updated: v2 3/6 -> v3 1/3, v2 4/6 -> v3 2/3, v2 6/6 -> v3 3/3
- [1/3] Change from "Fix" to "Implement" as multi-stream support is for newer SoCs not present when the driver was merged (Laurent)
- [1/3] Remove Fixes and Cc: stable tags (Laurent)
- [1/3] Store input/input_stream in mxc_isi_pipe instead of using per-stream counters array, avoiding arbitrary 64-entry limit (Laurent)
- [1/3] Use UINT_MAX to mark pipe as inactive to distinguish from valid pad 0
- [2/3] Remove "high-end" from description as RAW16 is common now (Laurent)
- [2/3] Add Y16 (16-bit monochrome) format support (Laurent)
- [2/3] Add Reviewed-by tag from Laurent
- [3/3] Drop M2M_OUT for ABGR32/BGRA32/RGBA32 as ISI ignores alpha bits (Laurent)
- [3/3] Remove Android requirements from commit message as alpha formats cannot be used as M2M input (Laurent)
- [3/3] Add Tested-by tag from Laurent Pinchart
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- [1/6] Split v1 patch 1/5 into two patches: this patch fixes the core for_each_active_route() bug, next patch adds additional stream validation (Frank Li)
- [2/6] New patch split from v1 1/5: adds stream ID validation on top of for_each_active_route() fix (Frank Li)
- [2/6] Remove incorrect sink_stream validation
- [3/6] Use fixed-size array for enabled_count instead of dynamic allocation
- [3/6] Use BIT_ULL() macro for u64 bitmask operations
- [3/6] Use MXC_ISI_MAX_STREAMS (64) as loop boundary instead of num_sources
- [3/6] Remove mxc_isi_stream_counters_alloc/free functions
- [4/6] Add Reviewed-by tag from Frank Li
- [5/6] Reword commit description for clarity (Frank Li)
- [6/6] Add Reviewed-by tag from Frank Li
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Guoniu Zhou (3):
media: nxp: imx8-isi: Use BIT_ULL() for 64-bit stream masks
media: nxp: imx8-isi: Implement per-stream reference counting for multiplexed streams
media: nxp: imx8-isi: Add additional 32-bit RGB format support

Laurentiu Palcu (1):
media: nxp: imx8-isi: Add 16-bit raw Bayer format support

 .../media/platform/nxp/imx8-isi/imx8-isi-core.h    |  5 +-
 .../platform/nxp/imx8-isi/imx8-isi-crossbar.c      | 88 ++++++++++++++------
 .../media/platform/nxp/imx8-isi/imx8-isi-pipe.c    | 31 +++++++
 .../media/platform/nxp/imx8-isi/imx8-isi-video.c   | 96 ++++++++++++++++++++++
 4 files changed, 195 insertions(+), 25 deletions(-)

---
base-commit: 4d32fbba9d23f50d157ed4a37c9e8fbce61c904a
change-id: 20260626-isi-00f05b044ac9

Best regards,

Signature · 1 line
Guoniu Zhou <[email protected]>