Skip to content

RFC Introduce capable_noaudit

[email protected] linux-fsdevel linux-security-module linux-xfs lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 20 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4capabily: Add new capable_noauditinclude/linux/capability.h kernel/capability.c+22 -06 replies
2/4quota: Don't issue audit messages on quota enforcingfs/quota/dquot.c+1 -12 replies
3/4xfs: replace ns_capable_noaudit()fs/xfs/xfs_trans_dquot.c+1 -15 replies
4/4capability: unexport has_capability_noauditkernel/capability.c+0 -13 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDarrick J. WongChristoph HellwigSerge Hallyn
1/4R-b R-b
2/4R-b R-b
3/4R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [RFC PATCH 0/4] Introduce capable_noaudit

From: Carlos Maiolino <[email protected]>

In some cases - filesystems quota specifically here - we'd like to check for effective capabilities without issuing spurious audit messages and without the need to specify a namespace for that.

This series introduce capable_noaudit() which has the same goal as capable() but without firing audit messages.

Also, this updates both generic quota and xfs quota code to use that.

The last patch unexports has_capability_noaudit() which was originally exported to be used in xfs but turns out it does not meet our needs.

Note this is based on top of a current series I have to remove has_capability_noaudit() calls from xfs so the xfs patch won't apply cleanly without that series.

If adding this helper is acceptable, I'll turn this into a non-rfc series with the required changes to apply properly.

Comments? Flames?
Cheers

Carlos Maiolino (4):
capabily: Add new capable_noaudit
quota: Don't issue audit messages on quota enforcing
xfs: replace ns_capable_noaudit()
capability: unexport has_capability_noaudit

 fs/quota/dquot.c           |  2 +-
 fs/xfs/xfs_trans_dquot.c   |  2 +-
 include/linux/capability.h |  5 +++++
 kernel/capability.c        | 18 +++++++++++++++++-
 4 files changed, 24 insertions(+), 3 deletions(-)
Signature · 1 line
2.54.0