Skip to content

xhci: avoid futile stop endpoint command and host teardown

Mathias Nyman linux-usb 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xhci: include all root port children in recovery prevention on link errordrivers/usb/host/xhci-ring.c drivers/usb/host/xhci.c drivers/usb/host/xhci.h+17 -230 replies
2/3xhci: prevent endpoint recovery after roothub disconnectdrivers/usb/host/xhci-ring.c drivers/usb/host/xhci.h+9 -40 replies
3/3xhci: avoid xHC endpoint changes after disconnect or link error.drivers/usb/host/xhci-ring.c drivers/usb/host/xhci.c drivers/usb/host/xhci.h+21 -40 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchXu Rao
SeriesT-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFT PATCH 0/3] xhci: avoid futile stop endpoint command and host teardown

This series is an attempt to avoid stop endpoint command failure leading to xhci teardown with messages:

xHCI host not responding to stop endpoint command
xHCI host controller not responding, assume dead

Series is based on a discussion with Michal and Xu Rao:

https://lore.kernel.org/linux-usb/[email protected]/

A Renesas xHC host with a device behind a disconnected hub failed to complete a stop endoint command immediately after a endpoint soft reset and restart. Michal had some plausible theories why stop endpoint command issued immediately after endpoint restart fails after disconnect.

Many of these cases can be avoided as xhci driver knows the rootport link state and can avoid futile transfer retry and recovery on link error or disconnect

I don't have a easy way to reproduce this myself, all testing is welcome

Thanks
Mathias

Mathias Nyman (3):
xhci: include all root port children in recovery prevention on link
error
xhci: prevent endpoint recovery after roothub disconnect
xhci: avoid xHC endpoint changes after disconnect or link error.

 drivers/usb/host/xhci-ring.c | 50 +++++++++++++++++++++++++-----------
 drivers/usb/host/xhci.c      |  9 ++++---
 drivers/usb/host/xhci.h      | 11 +++-----
 3 files changed, 43 insertions(+), 27 deletions(-)
Signature · 1 line
2.43.0