clk: mediatek: fix memory leak on module removal
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 9 repliesIn review
- v11 patch 2 repliesSuperseded
Changes in v2 from the cover letter
- Add a newline between platform_set_drvdata() and return (suggested by Brian Masney)
- Split the patch per SoC, (also suggested by Brian Masney)
- Add "Cc: [email protected]"
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | clk: mediatek: mt2712: fix memory leak on module removaldrivers/ | +2 | 1 reply | |
| 2/6 | clk: mediatek: mt6795: fix memory leak on module removaldrivers/ drivers/ drivers/ | +6 | 1 reply | |
| 3/6 | clk: mediatek: mt7622: fix memory leak on module removaldrivers/ drivers/ | +4 | 1 reply | |
| 4/6 | clk: mediatek: mt8135: fix memory leak on module removaldrivers/ | +2 | 1 reply | |
| 5/6 | clk: mediatek: mt8173: fix memory leak on module removaldrivers/ drivers/ | +4 | 4 replies | |
| 6/6 | clk: mediatek: mt8192: fix memory leak on module removaldrivers/ | +2 | 1 reply |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Brian Masney |
|---|---|
| 1/6 | R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/6] clk: mediatek: fix memory leak on module removal
Some MediaTek clock drivers do not call platform_set_drvdata() during probe,
but their remove callback calls platform_get_drvdata(). This results in platform_get_drvdata() returning NULL, which leads to calling kfree(NULL) in mtk_free_clk_data(NULL). This leaves clk_data unreleased, causing a memory leak.
Fix this by calling platform_set_drvdata() during probe.
Changes in v2:
- Add a newline between platform_set_drvdata() and return (suggested by Brian Masney)
- Split the patch per SoC, (also suggested by Brian Masney)
- Add "Cc: [email protected]"
Link to v1: https://lore.kernel.org/linux-mediatek/[email protected]/T/#u
Akari Tsuyukusa (6):
clk: mediatek: mt2712: fix memory leak on module removal
clk: mediatek: mt6795: fix memory leak on module removal
clk: mediatek: mt7622: fix memory leak on module removal
clk: mediatek: mt8135: fix memory leak on module removal
clk: mediatek: mt8173: fix memory leak on module removal
clk: mediatek: mt8192: fix memory leak on module removal
drivers/clk/mediatek/clk-mt2712-apmixedsys.c | 2 ++ drivers/clk/mediatek/clk-mt6795-apmixedsys.c | 2 ++ drivers/clk/mediatek/clk-mt6795-infracfg.c | 2 ++ drivers/clk/mediatek/clk-mt6795-pericfg.c | 2 ++ drivers/clk/mediatek/clk-mt7622-apmixedsys.c | 2 ++ drivers/clk/mediatek/clk-mt7622-infracfg.c | 2 ++ drivers/clk/mediatek/clk-mt8135-apmixedsys.c | 2 ++ drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 2 ++ drivers/clk/mediatek/clk-mt8173-infracfg.c | 2 ++ drivers/clk/mediatek/clk-mt8192-apmixedsys.c | 2 ++ 10 files changed, 20 insertions(+)
Signature · 1 line
2.54.0