selftests/damon: misc fixes for test bugs
Status from this message: [merged mm-stable] selftests-damon-fix-dead-code-skipped-checks-and-broken-lookups.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first
Changes in v3 from the cover letter
- v2: https://lore.kernel.org/[email protected]
- Rebase to latest mm-new.
Patches in v3 All 3 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | selftests/damon: prevent cross-context state pollution in DamonCtxtools/ | +8 | 1 reply | Applied |
| 2/3 | selftests/damon/damos_tried_regions: fix expectation output and join TypeErrortools/ | +2 | 0 replies | Applied |
| 3/3 | selftests/damon: fix dead code, skipped checks, and broken lookupstools/ tools/ tools/ +4 more | +10 | 0 replies | Applied |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | SJ Park |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/3] selftests/damon: misc fixes for test bugs
This series fixes several bugs in the DAMON selftests. Most are trivial but makes test output wrong or even silently pass the one test case for 'avail_operation' file existence check.
Patch 1 fixes mutable default arguments in DamonCtx.__init__() that cause state to leak between test instances.
Patch 2 fixes wrong operator precedence and join TypeError in damos_tried_regions.py.
Patch 3 fixes several wrong strings that produce dead elif branches, skipped file existence checks, and broken dict key lookups.
Changes from v2:
- v2: https://lore.kernel.org/[email protected]
- Rebase to latest mm-new.
Changes from v1:
- v1: https://lore.kernel.org/[email protected]
- Fix From:/Signed-off-by mismatch.
- Add Reviewed-by tags from SJ Park.
- Drop the duplicate memcg_path fix.
- Drop the empty aggregation-cycle retry fix pending root-cause investigation.
- No code change
Kunwu Chan (3):
selftests/damon: prevent cross-context state pollution in DamonCtx selftests/damon/damos_tried_regions: fix expectation output and join
TypeError
selftests/damon: fix dead code, skipped checks, and broken lookups
tools/testing/selftests/damon/_damon_sysfs.py | 12 +++++++++--- .../testing/selftests/damon/damos_apply_interval.py | 2 +- tools/testing/selftests/damon/damos_quota_goal.py | 2 +- tools/testing/selftests/damon/damos_tried_regions.py | 4 ++-- .../selftests/damon/drgn_dump_damon_status.py | 2 +- tools/testing/selftests/damon/sysfs.py | 4 ++-- tools/testing/selftests/damon/sysfs.sh | 6 +++--- ...fs_update_schemes_tried_regions_wss_estimation.py | 2 +- 8 files changed, 20 insertions(+), 14 deletions(-)
base-commit: 1f7264da0cec89427b167cc51930dd8c169dade4
Signature · 1 line
2.47.3