Skip to content

drm/amd/display: Fix DM IRQ teardown races

Geoffrey McRae amd-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Remove irq_fini_in_progress flag; the spinlock serialization and empty-list check are sufficient (Leo Li)
- Remove redundant irq_wq != NULL check in amdgpu_dm_irq_schedule_work; amdgpu_dm_irq_init() already guarantees it is valid (Leo Li)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/amd/display: Fix DM IRQ teardown racesdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c+70 -791 reply
2/2drm/amd/display: Use unbound workqueues for deferred DM workdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c+32 -31 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchLeo Li
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] drm/amd/display: Fix DM IRQ teardown races

Changes since v1:
- Remove irq_fini_in_progress flag; the spinlock serialization and empty-list check are sufficient (Leo Li)
- Remove redundant irq_wq != NULL check in amdgpu_dm_irq_schedule_work; amdgpu_dm_irq_init() already guarantees it is valid (Leo Li)

Geoffrey McRae (2):
drm/amd/display: Fix DM IRQ teardown races drm/amd/display: Use unbound workqueues for deferred DM work

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |   8 +-
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h |   4 +
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 172 ++++++++++--------
 3 files changed, 102 insertions(+), 82 deletions(-)
Signature · 1 line
2.43.0