net: enetc: cleanups and improvements
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest posting 2/214 patches 11 repliesApplied 14/14
- v4 posting 1/214 patches 1 replySuperseded
- v314 patches 4 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 14 patches | 4 replies | Superseded | |
| v1 | 14 patches | 3 replies | Superseded |
Changes in v4 from the cover letter
1. Improve enetc4_set_si_msix_num()
2. Update commit messages
v3 link: https://lore.kernel.org/imx/[email protected]/
v2 link: https://lore.kernel.org/imx/[email protected]/
v1 link: https://lore.kernel.org/imx/[email protected]/
---
Patches in v4 posting 2/2 All 14 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | net: enetc: extract common helpers for MAC promiscuous mode settingdrivers/ drivers/ drivers/ +4 more | +56 | 1 reply | Applied |
| 2/14 | net: enetc: extract common helpers for MAC hash filter configurationdrivers/ drivers/ drivers/ +1 more | +73 | 0 replies | Applied |
| 3/14 | net: enetc: convert ndo_set_rx_mode() to ndo_set_rx_mode_async()drivers/ drivers/ | +58 | 0 replies | Applied |
| 4/14 | net: enetc: improve MAFT entry management with bitmap trackingdrivers/ drivers/ drivers/ +1 more | +96 | 0 replies | Applied |
| 5/14 | net: enetc: use PCI device name for debugfs directorydrivers/ | +1 | 1 reply | Applied |
| 6/14 | net: enetc: simplify enetc4_set_port_speed()drivers/ drivers/ | +10 | 0 replies | Applied |
| 7/14 | net: enetc: differentiate phylink capabilities for pseudo-MAC and standalone MACdrivers/ drivers/ drivers/ | +32 | 1 reply | Applied |
| 8/14 | net: enetc: remove invalid code from enetc4_pl_mac_link_up()drivers/ drivers/ drivers/ | +1 | 0 replies | Applied |
| 9/14 | net: enetc: open-code enetc4_set_default_si_vlan_promisc()drivers/ | +3 | 1 reply | Applied |
| 10/14 | net: enetc: refactor SI VLAN promiscuous mode configurationdrivers/ drivers/ drivers/ | +16 | 2 replies | Applied |
| 11/14 | net: enetc: move enetc_set_si_vlan_promisc() to enetc_pf_common.cdrivers/ drivers/ drivers/ +1 more | +25 | 1 reply | Applied |
| 12/14 | net: enetc: remove redundant num_vsi field from enetc_port_capsdrivers/ drivers/ drivers/ | +68 | 0 replies | Applied |
| 13/14 | net: enetc: use alloc_etherdev_mqs() to create netdev for VF driverdrivers/ | +8 | 3 replies | Applied |
| 14/14 | net: enetc: use kzalloc_flex() for enetc_psfp_gate allocationdrivers/ | +1 | 1 reply | Applied |
Reviews trailers per patch
10 of 14 patches have a Reviewed-by or Acked-by.
| Patch | Maxime Chevallier | Joe Damato |
|---|---|---|
| 1/14 | R-b | |
| 2/14 | ||
| 3/14 | ||
| 4/14 | ||
| 5/14 | R-b | |
| 6/14 | R-b | |
| 7/14 | R-b | |
| 8/14 | R-b | |
| 9/14 | R-b | |
| 10/14 | R-b | |
| 11/14 | R-b | |
| 12/14 | ||
| 13/14 | R-b | |
| 14/14 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH RESEND v4 net-next 00/14] net: enetc: cleanups and improvements
From: Wei Fang <[email protected]>
The first group of patches (1, 2, 5-7) eliminates code duplication between the ENETC v1 and v4 drivers. Since both hardware generations share identical register layouts for MAC promiscuous mode, MAC hash filters, and VLAN promiscuous mode - differing only in register address offsets - common helper functions are extracted into enetc_pf_common.c and shared by both drivers.
Patch 3 converts ndo_set_rx_mode() to ndo_set_rx_mode_async(), removing the dedicated workqueue that was previously needed to defer MAC address list updates to a sleepable context.
Patch 4 replaces counter-based MAFT entry tracking with a bitmap, which keeps hardware and software state in sync and avoids partial failures during entry allocation.
Patches 8 and 9 fix phylink-related issues: removing invalid code from enetc4_pl_mac_link_up() and properly differentiating phylink capabilities between pseudo-MAC and standalone MAC.
The remaining patches (10-14) are minor cleanups: removing a redundant VLAN promiscuous mode initialization in probe, using the PCI device name for the debugfs directory, simplifying port speed configuration, removing a redundant num_vsi field, using alloc_etherdev_mqs() for the VF driver, and using kzalloc_flex() for a flexible array allocation.
---
v4 link: https://lore.kernel.org/imx/[email protected]/
v4:
1. Improve enetc4_set_si_msix_num()
2. Update commit messages
v3 link: https://lore.kernel.org/imx/[email protected]/
v2 link: https://lore.kernel.org/imx/[email protected]/
v1 link: https://lore.kernel.org/imx/[email protected]/
---
Claudiu Manoil (1):
net: enetc: differentiate phylink capabilities for pseudo-MAC and
standalone MAC
Wei Fang (13):
net: enetc: extract common helpers for MAC promiscuous mode setting
net: enetc: extract common helpers for MAC hash filter configuration
net: enetc: convert ndo_set_rx_mode() to ndo_set_rx_mode_async()
net: enetc: improve MAFT entry management with bitmap tracking
net: enetc: use PCI device name for debugfs directory
net: enetc: simplify enetc4_set_port_speed()
net: enetc: remove invalid code from enetc4_pl_mac_link_up()
net: enetc: open-code enetc4_set_default_si_vlan_promisc()
net: enetc: refactor SI VLAN promiscuous mode configuration
net: enetc: move enetc_set_si_vlan_promisc() to enetc_pf_common.c
net: enetc: remove redundant num_vsi field from enetc_port_caps
net: enetc: use alloc_etherdev_mqs() to create netdev for VF driver
net: enetc: use kzalloc_flex() for enetc_psfp_gate allocation
drivers/net/ethernet/freescale/enetc/enetc.h | 4 +- .../ethernet/freescale/enetc/enetc4_debugfs.c | 42 +- .../net/ethernet/freescale/enetc/enetc4_hw.h | 6 +- .../net/ethernet/freescale/enetc/enetc4_pf.c | 471 ++++++++---------- .../ethernet/freescale/enetc/enetc_ethtool.c | 2 +- .../net/ethernet/freescale/enetc/enetc_hw.h | 12 +- .../net/ethernet/freescale/enetc/enetc_pf.c | 94 +--- .../net/ethernet/freescale/enetc/enetc_pf.h | 6 - .../freescale/enetc/enetc_pf_common.c | 150 +++++- .../freescale/enetc/enetc_pf_common.h | 5 + .../net/ethernet/freescale/enetc/enetc_qos.c | 4 +- .../net/ethernet/freescale/enetc/enetc_vf.c | 9 +- include/linux/fsl/ntmp.h | 2 + 13 files changed, 411 insertions(+), 396 deletions(-)
Signature · 1 line
2.34.1