Skip to content

Change XEN_DOMCTL_setvcpuaffinity interface

Juergen Gross xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tools/libxl: don't rely on xc_vcpu_setaffinity() returned cpumapstools/libs/light/libxl_sched.c+9 -00 replies
2/3xen: don't let XEN_DOMCTL_setvcpuaffinity return the new affinitiesxen/common/sched/core.c xen/include/public/domctl.h+11 -380 replies
3/3tools/libxenctrl: rename parameters of xc_vcpu_setaffinity()tools/include/xenctrl.h tools/libs/ctrl/xc_domain.c+18 -340 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface

Today the XEN_DOMCTL_setvcpuaffinity hypercall will not only change the affinity settings of a vcpu, it will return the new effective settings, too.

In case an error happens during this hypercall, the expectation of the caller is that the affinity of the vcpu didn't change. This isn't true, however, if passing the new effective affinity back to the user is failing.

Instead of making error handling in the hypervisor even more complex, just change the interface by NOT passing back the new affinity. It can easily be obtained by another XEN_DOMCTL_getvcpuaffinity call if needed.

Juergen Gross (3):
tools/libxl: don't rely on xc_vcpu_setaffinity() returned cpumaps
xen: don't let XEN_DOMCTL_setvcpuaffinity return the new affinities tools/libxenctrl: rename parameters of xc_vcpu_setaffinity()

 tools/include/xenctrl.h        | 26 +++++-----------------
 tools/libs/ctrl/xc_domain.c    | 26 ++++++++++------------
 tools/libs/light/libxl_sched.c |  9 ++++++++
 xen/common/sched/core.c        | 40 ++++++++--------------------------
 xen/include/public/domctl.h    |  9 ++------
 5 files changed, 38 insertions(+), 72 deletions(-)
Signature · 1 line
2.54.0