Skip to content

drm/i915/dp_link: Unify modeset/fallback config selection

Imre Deak intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest34 patches 47 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/34drm/i915/doc: Document DP link capabilitiesDocumentation/gpu/intel-display/dp-link-capabilities.rst Documentation/gpu/intel-display/index.rst drivers/gpu/drm/i915/display/intel_dp_link_caps.c+93 -01 reply
2/34drm/i915/dp_link_caps: Factor out helper to get link config by indexdrivers/gpu/drm/i915/display/intel_dp_link_caps.c+14 -41 reply
3/34drm/i915/dp_link_caps: Add support for link rate, lane count iteration ordersdrivers/gpu/drm/i915/display/intel_dp_link_caps.c+50 -01 reply
4/34drm/i915/dp_link_caps: Add link configuration iteratordrivers/gpu/drm/i915/display/intel_dp_link_caps.c drivers/gpu/drm/i915/display/intel_dp_link_caps.h+319 -01 reply
5/34drm/i915/dp_link_caps: Add helper to get iteration order for a connectordrivers/gpu/drm/i915/display/intel_dp_link_caps.c drivers/gpu/drm/i915/display/intel_dp_link_caps.h+55 -01 reply
6/34drm/i915/dp_link_caps: Validate max link limitsdrivers/gpu/drm/i915/display/intel_dp_link_caps.c+27 -11 reply
7/34drm/i915/dp_link_caps: Add filter for enabled link configurationsdrivers/gpu/drm/i915/display/intel_dp_link_caps.c+34 -41 reply
8/34drm/i915/dp_link_caps: Re-enable link configurations after a link resetdrivers/gpu/drm/i915/display/intel_dp_link_caps.c+7 -11 reply
9/34drm/i915/dp_link_caps: Re-enable link configurations after sink caps changedrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp_link_caps.c drivers/gpu/drm/i915/display/intel_dp_link_caps.h+43 -51 reply
10/34drm/i915/dp_link_caps: Drop noupdate postfix from max link limit set helpersdrivers/gpu/drm/i915/display/intel_dp_link_caps.c+7 -81 reply
11/34drm/i915/dp_link_caps: Add debugfs entry showing allowed configurationsdrivers/gpu/drm/i915/display/intel_dp_link_caps.c+40 -01 reply
12/34drm/i915/dp: Add link configuration filter for modeset computationdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp.h drivers/gpu/drm/i915/display/intel_dp_link_caps.c +1 more+102 -32 replies
13/34drm/i915/dp_link_caps: Add helper to query max BW link configurationdrivers/gpu/drm/i915/display/intel_dp_link_caps.c drivers/gpu/drm/i915/display/intel_dp_link_caps.h+20 -01 reply
14/34drm/i915/dp: Query max BW config via link_caps during mode validationdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp.h drivers/gpu/drm/i915/display/intel_dp_mst.c+18 -101 reply
15/34drm/i915/dp_tunnel: Query max BW config via link_caps for BW computationdrivers/gpu/drm/i915/display/intel_dp_link_caps.c drivers/gpu/drm/i915/display/intel_dp_link_caps.h drivers/gpu/drm/i915/display/intel_dp_tunnel.c+6 -51 reply
16/34drm/i915/dp_test: Use link caps for compliance link configsdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp_test.c drivers/gpu/drm/i915/display/intel_dp_test.h+99 -31 reply
17/34drm/i915/dp: Iterate configurations via link_caps for SST non-DSCdrivers/gpu/drm/i915/display/intel_dp.c+24 -251 reply
18/34drm/i915/dp: Iterate configurations via link_caps for SST DSCdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp_link_caps.c drivers/gpu/drm/i915/display/intel_dp_link_caps.h+44 -541 reply
19/34drm/i915/dp: Use link caps for eDP DSC config selectiondrivers/gpu/drm/i915/display/intel_dp.c+14 -32 replies
20/34drm/i915/dp_mst: Use link caps for non-DSC config selectiondrivers/gpu/drm/i915/display/intel_dp_mst.c+14 -21 reply
21/34drm/i915/dp_mst: Use link caps for MST DSC config selectiondrivers/gpu/drm/i915/display/intel_dp_mst.c+33 -71 reply
22/34drm/i915/dp: Remove min/max link config limitsdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp.h drivers/gpu/drm/i915/display/intel_dp_link_caps.c +2 more+2 -1191 reply
23/34drm/i915/dp_link_training: Reset the max link limits in the fallback codedrivers/gpu/drm/i915/display/intel_dp_link_training.c+34 -51 reply
24/34drm/i915/dp_link_training: Use config iterator for fallbackdrivers/gpu/drm/i915/display/intel_dp_link_caps.c drivers/gpu/drm/i915/display/intel_dp_link_caps.h drivers/gpu/drm/i915/display/intel_dp_link_training.c+39 -1581 reply
25/34drm/i915/dp_link_training: Disable failed config during fallbackdrivers/gpu/drm/i915/display/intel_dp_link_caps.c drivers/gpu/drm/i915/display/intel_dp_link_caps.h drivers/gpu/drm/i915/display/intel_dp_link_training.c+77 -01 reply
26/34drm/i915/kunit: Enable KUnit testsdrivers/gpu/drm/i915/.kunitconfig drivers/gpu/drm/i915/Kconfig.debug+24 -03 replies
27/34drm/i915/kunit: Add DP link test stubdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/tests/Makefile drivers/gpu/drm/i915/display/tests/intel_dp_link_test.c+56 -01 reply
28/34drm/xe/kunit: Add display test configdrivers/gpu/drm/xe/.gitignore drivers/gpu/drm/xe/.kunitconfig-display+12 -04 replies
29/34drm/xe/kunit: Build DP link display testsdrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/display/tests/Makefile+14 -04 replies
30/34drm/i915/kunit: Setup DP link test contextdrivers/gpu/drm/i915/display/tests/intel_dp_link_test.c+50 -02 replies
31/34drm/i915/kunit: Export link training and caps funcs for testingdrivers/gpu/drm/i915/display/intel_dp_link_caps.c drivers/gpu/drm/i915/display/intel_dp_link_caps.h drivers/gpu/drm/i915/display/intel_dp_link_training.c +2 more+148 -22 replies
32/34drm/i915/kunit: DP link: add baseline fixed table reference testdrivers/gpu/drm/i915/display/tests/intel_dp_link_test.c+200 -03 replies
33/34drm/i915/kunit: DP link: add update config testsdrivers/gpu/drm/i915/display/tests/intel_dp_link_test.c+780 -03 replies
34/34drm/i915/kunit: DP link: add fallback testsdrivers/gpu/drm/i915/display/tests/intel_dp_link_test.c+318 -02 replies

Reviews trailers per patch

All 34 patches have a Reviewed-by or Acked-by.

PatchSuraj KandpalLuca CoelhoMichał GrzelakRodrigo Vivi
1/34R-b
2/34R-b
3/34R-b
4/34R-b
5/34R-b
6/34R-b
7/34R-b
8/34R-b
9/34R-b
10/34R-b
11/34R-b
12/34R-b
13/34R-b
14/34R-b
15/34R-b
16/34R-b
17/34R-b
18/34R-b
19/34R-b
20/34R-b
21/34R-b
22/34R-b
23/34R-b
24/34R-b
25/34R-b
26/34R-b R-b
27/34R-b
28/34R-b A-b
29/34R-b R-b A-b
30/34R-b
31/34R-b
32/34R-b R-b
33/34R-b R-b
34/34R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/34] drm/i915/dp_link: Unify modeset/fallback config selection

This is v2 of the third part of patchset [1], unifying the link configuration selection logic used during modeset state computation and link training fallback selection, while also adding the corresponding KUnit tests. This constitutes patches 58–108 of [1] and, once merged, completes the original patchset. Due to the simplifications introduced in this version explained below, several patches from the original patchset have been dropped.

The patchset is based on the already merged first [2] and second [3] part of patchset [1].

For the rationale of this patchset, please refer to the parts related to link configuration selection in the cover letter of [1].

This v2 patchset version has the following changes:
- Track the state of link config iteration in an iteration object. (Jani)
- Use an opaque filter object for filtering the iterated configurations instead of exposing configuration indices via the API. (Jani)
- Remove all parts of the API accepting or returning a configuration index or position. (Jani)
- Use the config iterator for fallback selection. (Jani)
- Remove the change to track link configurations via a virtual indexing scheme. (Ville)
- Remove the functionality to merge new link configurations for a connected sink changing its capabilities, allowed by patchset [4] already merged. (Ville)
- Use the max BW link configuration during mode validation and TBT BW computation, instead of using the max link limits for these.

Cc Jani Nikula <[email protected]>
Cc Ville Syrjälä <[email protected]>

[1] https://lore.kernel.org/all/[email protected]
[2] https://lore.kernel.org/all/[email protected]
[3] https://lore.kernel.org/all/[email protected]
[4] https://lore.kernel.org/all/[email protected]

Imre Deak (34):
drm/i915/doc: Document DP link capabilities drm/i915/dp_link_caps: Factor out helper to get link config by index drm/i915/dp_link_caps: Add support for link rate, lane count iteration
orders
drm/i915/dp_link_caps: Add link configuration iterator drm/i915/dp_link_caps: Add helper to get iteration order for a
connector
drm/i915/dp_link_caps: Validate max link limits drm/i915/dp_link_caps: Add filter for enabled link configurations drm/i915/dp_link_caps: Re-enable link configurations after a link
reset
drm/i915/dp_link_caps: Re-enable link configurations after sink caps
change
drm/i915/dp_link_caps: Drop noupdate postfix from max link limit set
helpers
drm/i915/dp_link_caps: Add debugfs entry showing allowed
configurations
drm/i915/dp: Add link configuration filter for modeset computation drm/i915/dp_link_caps: Add helper to query max BW link configuration drm/i915/dp: Query max BW config via link_caps during mode validation drm/i915/dp_tunnel: Query max BW config via link_caps for BW
computation
drm/i915/dp_test: Use link caps for compliance link configs drm/i915/dp: Iterate configurations via link_caps for SST non-DSC drm/i915/dp: Iterate configurations via link_caps for SST DSC drm/i915/dp: Use link caps for eDP DSC config selection drm/i915/dp_mst: Use link caps for non-DSC config selection drm/i915/dp_mst: Use link caps for MST DSC config selection drm/i915/dp: Remove min/max link config limits drm/i915/dp_link_training: Reset the max link limits in the fallback
code
drm/i915/dp_link_training: Use config iterator for fallback drm/i915/dp_link_training: Disable failed config during fallback drm/i915/kunit: Enable KUnit tests
drm/i915/kunit: Add DP link test stub
drm/xe/kunit: Add display test config
drm/xe/kunit: Build DP link display tests
drm/i915/kunit: Setup DP link test context
drm/i915/kunit: Export link training and caps funcs for testing drm/i915/kunit: DP link: add baseline fixed table reference test drm/i915/kunit: DP link: add update config tests drm/i915/kunit: DP link: add fallback tests

 .../intel-display/dp-link-capabilities.rst    |   11 +
 Documentation/gpu/intel-display/index.rst     |    1 +
 drivers/gpu/drm/i915/.kunitconfig             |   12 +
 drivers/gpu/drm/i915/Kconfig.debug            |   12 +
 drivers/gpu/drm/i915/Makefile                 |    2 +
 drivers/gpu/drm/i915/display/intel_dp.c       |  291 ++--
 drivers/gpu/drm/i915/display/intel_dp.h       |   11 +-
 .../gpu/drm/i915/display/intel_dp_link_caps.c |  759 ++++++++-
 .../gpu/drm/i915/display/intel_dp_link_caps.h |  172 +-
 .../drm/i915/display/intel_dp_link_training.c |  237 +--
 .../drm/i915/display/intel_dp_link_training.h |   31 +
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |   72 +-
 drivers/gpu/drm/i915/display/intel_dp_test.c  |  107 +-
 drivers/gpu/drm/i915/display/intel_dp_test.h  |    3 +-
 .../gpu/drm/i915/display/intel_dp_tunnel.c    |    8 +-
 drivers/gpu/drm/i915/display/tests/Makefile   |    7 +
 .../i915/display/tests/intel_dp_link_test.c   | 1412 +++++++++++++++++
 drivers/gpu/drm/xe/.gitignore                 |    1 +
 drivers/gpu/drm/xe/.kunitconfig-display       |   11 +
 drivers/gpu/drm/xe/Makefile                   |    3 +
 drivers/gpu/drm/xe/display/tests/Makefile     |   11 +
 21 files changed, 2786 insertions(+), 388 deletions(-)
 create mode 100644 Documentation/gpu/intel-display/dp-link-capabilities.rst
 create mode 100644 drivers/gpu/drm/i915/.kunitconfig
 create mode 100644 drivers/gpu/drm/i915/display/tests/Makefile
 create mode 100644 drivers/gpu/drm/i915/display/tests/intel_dp_link_test.c
 create mode 100644 drivers/gpu/drm/xe/.kunitconfig-display
 create mode 100644 drivers/gpu/drm/xe/display/tests/Makefile
Signature · 1 line
2.49.1