hw/arm/fsl-imx8mp: Add inital FlexCAN support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 10 repliesIn review
- v14 patches 5 repliesSuperseded
Changes in v2 from the cover letter
Thanks for the very helpful and super quick review, Phil! Here we go:
* Add patch "hw/net/can/flexcan: Wire clock control module via link property"
* Have separate MemoryRegionOps for 32 and 64 bit
[1] https://lore.kernel.org/qemu-devel/[email protected]/
---
base-commit: a59157f98f0b69b0bbdb26bc15fbc4d6c8060799
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | hw/net/can/flexcan: Wire clock control module via link propertyhw/ hw/ | +10 | 1 reply | |
| 2/5 | hw/net/can/flexcan: Subclass TYPE_CAN_FLEXCANhw/ hw/ include/ | +68 | 1 reply | |
| 3/5 | hw/arm/imx8mp-evk: Open code DEFINE_MACHINE_AARCH64hw/ | +13 | 0 replies | |
| 4/5 | hw/arm/imx8mp-evk: Introduce FslImx8mpEvkStatehw/ | +20 | 0 replies | |
| 5/5 | hw/arm: Add basic FlexCAN3 support to TYPE_FSL_IMX8MP and imx8mp-evkdocs/ hw/ hw/ +3 more | +72 | 0 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Philippe Mathieu-Daudé | Pavel Pisa |
|---|---|---|
| Series | A-b T-b | |
| 1/5 | R-b | |
| 2/5 | R-b | |
| 3/5 | R-b | |
| 4/5 | R-b | |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/5] hw/arm/fsl-imx8mp: Add inital FlexCAN support
Now that FlexCAN emulation has landed in master, let's add it to imx8mp-evk as well. While the real i.MX8M Plus supports CAN FD which isn't emulated yet, the non-FD mode works well under Linux: It is possible to use cangen and candump either way on the host and on the guest, as described in docs/system/devices/can.rst.
This series consists of five patches where the first four are preparations. The last patch integrates FlexCAN into the i.MX8M Plus SoC and EVK board. The first preparation addresses the review comment from [1], and could be applied independently.
It would be nice if this series could make it into 11.1.
Testing done:
* Start imx8mp-evk and run cangen can0 there. Observe on the host that candump vcan0 prints the traffic.
* make check
v2:
Thanks for the very helpful and super quick review, Phil! Here we go:
* Add patch "hw/net/can/flexcan: Wire clock control module via link property"
* Have separate MemoryRegionOps for 32 and 64 bit
[1] https://lore.kernel.org/qemu-devel/[email protected]/
---
base-commit: a59157f98f0b69b0bbdb26bc15fbc4d6c8060799
Bernhard Beschow (5):
hw/net/can/flexcan: Wire clock control module via link property hw/net/can/flexcan: Subclass TYPE_CAN_FLEXCAN hw/arm/imx8mp-evk: Open code DEFINE_MACHINE_AARCH64 hw/arm/imx8mp-evk: Introduce FslImx8mpEvkState
hw/arm: Add basic FlexCAN3 support to TYPE_FSL_IMX8MP and imx8mp-evk
docs/system/arm/imx8m.rst | 1 + include/hw/arm/fsl-imx8mp.h | 8 ++++ include/hw/net/flexcan.h | 4 +- hw/arm/fsl-imx6.c | 5 ++- hw/arm/fsl-imx8mp.c | 38 ++++++++++++++++ hw/arm/imx8mp-evk.c | 64 ++++++++++++++++++++++----- hw/misc/imx8mp_ccm.c | 3 ++ hw/net/can/flexcan.c | 88 ++++++++++++++++++++++++++++++------- hw/arm/Kconfig | 1 + 9 files changed, 182 insertions(+), 30 deletions(-)
Signature · 1 line
2.55.0