Skip to content

soc: apple: Add "PMGR misc" power controls driver

Sasha Finkelstein asahi linux-arm-kernel linux-devicetree lkml 3 versions – Applied

Status from this message: Thanks, applied! First two patches to apple-soc/drivers-7.3 and the dts one to apple-soc/dt-7.3.

Get series with b4
b4 am [email protected] change-id 20260702-pmgr-misc-ae1cbd5bc2c7

Versions newest first

  1. v3 Latest3 patches 2 repliesApplied
  2. v23 patches 4 repliesSuperseded
  3. v13 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- Remove ability to probe only one control, it is not used anyway
- Allow building as module
- Style fixes
- Link to v2: https://patch.msgid.link/[email protected]

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3dt-bindings: soc: apple: Add Apple PMGR misc controlsDocumentation/devicetree/bindings/soc/apple/apple,t6000-pmgr-misc.yaml MAINTAINERS+46 -00 replies
2/3soc: apple: Add driver for Apple PMGR misc controlsdrivers/soc/apple/Kconfig drivers/soc/apple/Makefile drivers/soc/apple/apple-pmgr-misc.c+193 -00 replies
3/3arm64: dts: apple: Add pmgr-misc nodes to t60xxarch/arm64/boot/dts/apple/t600x-die0.dtsi arch/arm64/boot/dts/apple/t602x-die0.dtsi+14 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchConor DooleySven PeterJoshua Peisach
SeriesR-b
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/3] soc: apple: Add "PMGR misc" power controls driver

Certain Apple SoCs have additional power state controls that are using a separate "misc" mmio interface. Currently this includes the fabric and memory controllers on pro/max/ultra SoCs.

This series adds a driver to put those in a low power state when the machine enters sleep. The power savings are SoC-dependent and are around 1W.

---
Changes in v3:
- Remove ability to probe only one control, it is not used anyway
- Allow building as module
- Style fixes
- Link to v2: https://patch.msgid.link/[email protected]

Changes in v2:
- Error handling fixes
- Reword binding description
- Link to v1: https://patch.msgid.link/[email protected]

---
Hector Martin (1):
soc: apple: Add driver for Apple PMGR misc controls

Sasha Finkelstein (2):
dt-bindings: soc: apple: Add Apple PMGR misc controls
arm64: dts: apple: Add pmgr-misc nodes to t60xx

 Documentation/devicetree/bindings/soc/apple/apple,t6000-pmgr-misc.yaml |  45 +++++++++++++++++++++++++++
 MAINTAINERS                                                            |   1 +
 arch/arm64/boot/dts/apple/t600x-die0.dtsi                              |   7 +++++
 arch/arm64/boot/dts/apple/t602x-die0.dtsi                              |   7 +++++
 drivers/soc/apple/Kconfig                                              |  10 ++++++
 drivers/soc/apple/Makefile                                             |   2 ++
 drivers/soc/apple/apple-pmgr-misc.c                                    | 181 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 7 files changed, 253 insertions(+)

---
base-commit: e5d9690657844a2645a518cdf838206f6daf513e
change-id: 20260702-pmgr-misc-ae1cbd5bc2c7

Best regards,

Signature · 1 line
Sasha Finkelstein <[email protected]>