ALSA: Remove redundant open helper return checks
Status from this message: Applied all patches to for-next branch now. Thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 2 repliesApplied
- v11 patch 0 repliesSuperseded
Changes in v2 from the cover letter
- Drop the unnecessary assignment of the return value from nonseekable_open()/stream_open(), as suggested by Takashi.
- Merge the individual patches into a single patch series.
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | ALSA: control: Drop redundant stream_open() return checksound/ | +1 | 0 replies | |
| 2/7 | ALSA: mixer: oss: Drop redundant nonseekable_open() return checksound/ | +1 | 0 replies | |
| 3/7 | ALSA: pcm: oss: Drop redundant nonseekable_open() return checksound/ | +1 | 0 replies | |
| 4/7 | ALSA: pcm: Drop redundant nonseekable_open() return checksound/ | +8 | 0 replies | |
| 5/7 | ALSA: rawmidi: Drop redundant stream_open() return checksound/ | +1 | 0 replies | |
| 6/7 | ALSA: seq: Drop redundant stream_open() return checksound/ | +1 | 0 replies | |
| 7/7 | ALSA: timer: Drop redundant stream_open() return checksound/ | +1 | 0 replies |
Reviews trailers per patch
None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Cezary Rojewski |
|---|---|
| Series | R-b |
| 1/7 | |
| 2/7 | |
| 3/7 | |
| 4/7 | |
| 5/7 | |
| 6/7 | |
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/7] ALSA: Remove redundant open helper return checks
From: bui duc phuc <[email protected]>
Hi all,
This series removes redundant error checks after calls to nonseekable_open() and stream_open() in the ALSA core.
nonseekable_open() always returns 0, so checking its return value is unnecessary.
Several users were later converted from nonseekable_open() to stream_open(), but the original error checks were retained. Since stream_open() also always returns 0, those checks are likewise unnecessary.
As a result, all patches simply remove dead error handling paths with no functional change.
Change in v2 :
- Drop the unnecessary assignment of the return value from nonseekable_open()/stream_open(), as suggested by Takashi.
- Merge the individual patches into a single patch series.
Best regards,
Phuc
bui duc phuc (7):
ALSA: control: Drop redundant stream_open() return check
ALSA: mixer: oss: Drop redundant nonseekable_open() return check
ALSA: pcm: oss: Drop redundant nonseekable_open() return check
ALSA: pcm: Drop redundant nonseekable_open() return check
ALSA: rawmidi: Drop redundant stream_open() return check
ALSA: seq: Drop redundant stream_open() return check
ALSA: timer: Drop redundant stream_open() return check
sound/core/control.c | 4 +--- sound/core/oss/mixer_oss.c | 4 +--- sound/core/oss/pcm_oss.c | 4 +--- sound/core/pcm_native.c | 14 ++++++++------ sound/core/rawmidi.c | 4 +--- sound/core/seq/seq_clientmgr.c | 5 +---- sound/core/timer.c | 5 +---- 7 files changed, 14 insertions(+), 26 deletions(-)
Signature · 1 line
2.43.0