Skip to content

drm/intel/display: Changes required to make vblank evasion PREEMPT_RT safe.

Maarten Lankhorst dri-devel intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drm/vblank_work: Add methods to schedule vblank_work in 2 stagesdrivers/gpu/drm/drm_vblank_work.c include/drm/drm_vblank_work.h+96 -260 replies
2/10drm/vblank: Add a 2-stage version of drm_crtc_arm_vblank_eventdrivers/gpu/drm/drm_vblank.c include/drm/drm_vblank.h+76 -20 replies
3/10drm/intel/display: Make intel_crtc_arm_vblank_event staticdrivers/gpu/drm/i915/display/intel_crtc.c drivers/gpu/drm/i915/display/intel_crtc.h+1 -21 reply
4/10drm/intel/display: Convert vblank event handling to 2-stage armingdrivers/gpu/drm/i915/display/intel_crtc.c+44 -400 replies
5/10drm/i915/display: Move vblank put until after critical sectiondrivers/gpu/drm/i915/display/intel_cursor.c+6 -20 replies
6/10drm/i915/display: Remove locking from intel_vblank_evade critical sectiondrivers/gpu/drm/i915/display/intel_crtc.c drivers/gpu/drm/i915/display/intel_vblank.c drivers/gpu/drm/i915/display/intel_vblank.h+15 -180 replies
7/10drm/i915/display: Handle vlv dsi workaround in scanline_in_safe_range toodrivers/gpu/drm/i915/display/intel_vblank.c+18 -180 replies
8/10drm/i915: Use preempt_disable/enable_rt() where recommendeddrivers/gpu/drm/i915/display/intel_vblank.c+33 -100 replies
9/10drm/i915/display: Make get_vblank_counter use intel_de_read_fw()drivers/gpu/drm/i915/display/intel_vblank.c+1 -11 reply
10/10drm/i915/display: Do not take uncore lock in i915_get_vblank_counterdrivers/gpu/drm/i915/display/intel_de.h drivers/gpu/drm/i915/display/intel_vblank.c drivers/gpu/drm/i915/intel_uncore.h +1 more+35 -101 reply

Reviews trailers per patch

4 of 10 patches have a Reviewed-by or Acked-by.

PatchUma ShankarVille Syrjälä
1/10
2/10
3/10R-b
4/10
5/10R-b
6/10
7/10R-b
8/10R-b
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] drm/intel/display: Changes required to make vblank evasion PREEMPT_RT safe.

CONFIG_PREEMPT_RT requires code to be as deterministic as possible, and codes with interrupts disabled cannot use spinlocks.

In order to handle this correctly, we ensure any locking requirements are handled before disabling interrupts, and only start locking again after interrupts are re-enabled and timing sensitive path completed.

This also has the benefit of making the vblank evasion code more deterministic; without locking there's much less jitter.

Previously, we scheduled vblank work on completion.
This is now handled by scheduling the vblank in advance, only arming it upon completion without locks.

Maarten Lankhorst (9):
drm/vblank_work: Add methods to schedule vblank_work in 2 stages drm/vblank: Add a 2-stage version of drm_crtc_arm_vblank_event drm/intel/display: Make intel_crtc_arm_vblank_event static drm/intel/display: Convert vblank event handling to 2-stage arming drm/i915/display: Move vblank put until after critical section drm/i915/display: Remove locking from intel_vblank_evade critical
section
drm/i915/display: Handle vlv dsi workaround in scanline_in_safe_range
too
drm/i915/display: Make get_vblank_counter use intel_de_read_fw() drm/i915/display: Do not take uncore lock in i915_get_vblank_counter

Mike Galbraith (1):
drm/i915: Use preempt_disable/enable_rt() where recommended

 drivers/gpu/drm/drm_vblank.c                  |  64 +++++++++-
 drivers/gpu/drm/drm_vblank_work.c             | 110 +++++++++++++----
 drivers/gpu/drm/i915/display/intel_crtc.c     |  86 ++++++-------
 drivers/gpu/drm/i915/display/intel_crtc.h     |   1 -
 drivers/gpu/drm/i915/display/intel_cursor.c   |   8 +-
 drivers/gpu/drm/i915/display/intel_de.h       |   8 ++
 drivers/gpu/drm/i915/display/intel_vblank.c   | 115 ++++++++++--------
 drivers/gpu/drm/i915/display/intel_vblank.h   |   1 +
 drivers/gpu/drm/i915/intel_uncore.h           |  26 ++--
 .../drm/xe/compat-i915-headers/intel_uncore.h |   7 ++
 include/drm/drm_vblank.h                      |  14 ++-
 include/drm/drm_vblank_work.h                 |  12 ++
 12 files changed, 324 insertions(+), 128 deletions(-)
Signature · 1 line
2.53.0