Skip to content

netfilter: ipset: gc, backlog and cidr patches

Jozsef Kadlecsik netfilter-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5netfilter: ipset: mark the rcu locked areas properlynet/netfilter/ipset/ip_set_hash_gen.h+5 -80 replies
2/5netfilter: ipset: exlude gc when resize is in progressnet/netfilter/ipset/ip_set_hash_gen.h+20 -110 replies
3/5netfilter: ipset: cleanup the add/del backlog when resize failednet/netfilter/ipset/ip_set_hash_gen.h+20 -80 replies
4/5netfilter: ipset: allocate the proper memory for the generic hash structurenet/netfilter/ipset/ip_set_hash_gen.h+11 -20 replies
5/5netfilter: ipset: rework cidr bookkeepingnet/netfilter/ipset/ip_set_hash_gen.h net/netfilter/ipset/ip_set_hash_ipportnet.c net/netfilter/ipset/ip_set_hash_net.c +4 more+175 -930 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] netfilter: ipset: gc, backlog and cidr patches

Hi Pablo,

Here follows three patches which addresses the gc-resize clashing in the comment extension, the add/del backlog cleanup in the error path and a fairly large rewriting of the cidr bookkeeping. The two other patches could be squeezed into the next ones on the list but I think they are a bit independent cleanups and clarifications.

The batch does not address the issue Florian pointed out about sashiko's complains about possible missing rcu locking and the possible torn reads, also from sashiko reports.

Best regards,
Jozsef

Jozsef Kadlecsik (5):
netfilter: ipset: mark the rcu locked areas properly
netfilter: ipset: exlude gc when resize is in progress
netfilter: ipset: cleanup the add/del backlog when resize failed
netfilter: ipset: allocate the proper memory for the generic hash
structure
netfilter: ipset: rework cidr bookkeeping

 net/netfilter/ipset/ip_set_hash_gen.h        | 311 ++++++++++++-------
 net/netfilter/ipset/ip_set_hash_ipportnet.c  |   4 +-
 net/netfilter/ipset/ip_set_hash_net.c        |   4 +-
 net/netfilter/ipset/ip_set_hash_netiface.c   |   4 +-
 net/netfilter/ipset/ip_set_hash_netnet.c     |  12 +-
 net/netfilter/ipset/ip_set_hash_netport.c    |   4 +-
 net/netfilter/ipset/ip_set_hash_netportnet.c |  12 +-
 7 files changed, 230 insertions(+), 121 deletions(-)
Signature · 1 line
2.39.5