KVM: arm64: vgic: Fix racy LPI release and re-registration handling
Status from this message: Applied to fixes, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest2 patches 1 replyApplied
- v52 patches 1 replySuperseded
- v42 patches 2 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 2 patches | 0 replies | Superseded | |
| v2 | 1 patch | 2 replies | Superseded | |
| v1 | 1 patch | 1 reply | Superseded |
Changes in v6 from the cover letter
* Remove pending_release in patch 1, preventing use-after-free and/or spurious WARNs.
* Avoid lock inversion via xa_release() (Sashiko).
Patches in v6 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | KVM: arm64: vgic: Fix race between LPI release and re-registrationarch/ arch/ include/ | +24 | 0 replies | |
| 2/2 | KVM: arm64: vgic: Mitigate potential LPI registration failurearch/ | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.
Cover letter [PATCH v6 0/2] KVM: arm64: vgic: Fix racy LPI release and re-registration handling
Fix a couple of potential issues that could arise from racy LPI release and re-registration for the same INTID.
The issue fixed in patch 1 can manifest itself through either a leaked LPI structure, or a prematurely deleted LPI. The issue fixed in patch 2 could materialize as a spurious -ENOMEM failure when registering an LPI.
v6:
* Remove pending_release in patch 1, preventing use-after-free and/or spurious WARNs.
* Avoid lock inversion via xa_release() (Sashiko).
v5:
* Make sure evicted IRQs on the registration path are pending release (Oliver Upton).
v4:
* Add __GFP_ACCOUNT to patch 2 (Sashiko).
v3:
* Use refcount_dec_and_lock_irqsave() instead of unconditionally grabbing the xarray lock in patch 1.
* Add patch 2.
v2:
* Address Sashiko's review. Fix the direct release path by decrementing the refcount under the xarray spinlock, preventing a UAF that would have been introduced in v1.
Carlos López (2):
KVM: arm64: vgic: Fix race between LPI release and re-registration
KVM: arm64: vgic: Mitigate potential LPI registration failure
arch/arm64/kvm/vgic/vgic-its.c | 25 +++++++++++++++++-------- arch/arm64/kvm/vgic/vgic.c | 18 ++++++++---------- include/kvm/arm_vgic.h | 3 --- 3 files changed, 25 insertions(+), 21 deletions(-)
base-commit: 1ee27dacbe5dc4def481794d899d67b0d4570094
Signature · 1 line
2.51.0