Skip to content

Rework pkey ioctl functions error paths

Harald Freudenberger linux-s390 2 versions – Applied

Status from this message: Applied, thank you!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest1 patch 1 replyApplied
  2. v21 patch 0 repliesSuperseded

Changelog from the cover letter

v1 - first version
v2 - just a rebase of the v1 patch as the original patch did not apply
any more.
v3 - Fix paths where a error ptr returned from a helper function may

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/1s390/pkey: Rework ioctl functions error pathsdrivers/s390/crypto/pkey_api.c+157 -1310 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchFinn Callies
1/1R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/1] Rework pkey ioctl functions error paths

Slight rework for all the pkey ioctl functions, especially related to the error paths with regard to free memory. This patch removes all this duplicated code and introduces one code block at the end of the functions which is jumped into via goto out or executed on regular exit.

Changelog:
v1 - first version
v2 - just a rebase of the v1 patch as the original patch did not apply
any more.
v3 - Fix paths where a error ptr returned from a helper function may

     be used as input for kfree(). Fixed typo pathes -> paths

v4 - Added yet another slight rework covering the possible use of an
uninitialized variable in an error path.
v5 - Resend without any code changes, just Finn's reviewed by added.

Harald Freudenberger (1):
s390/pkey: Rework ioctl functions error paths

 drivers/s390/crypto/pkey_api.c | 288 ++++++++++++++++++---------------
 1 file changed, 157 insertions(+), 131 deletions(-)

--
2.43.0