Skip to content

mtd: spi-nor: Rework flash parameter initialization

Michael Walle linux-mtd lkml 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 1 replyApplied
  2. v18 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- collected Tb and Rb tags
- Fixed the roll-back issue Sashiko found, we now keep two backups
for the parameters.
- Link to v1: https://lore.kernel.org/linux-mtd/[email protected]/

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/8mtd: spi-nor: spansion: s25fl256s0: remove SKIP_SFDP flagdrivers/mtd/spi-nor/spansion.c+1 -10 replies
2/8mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failuredrivers/mtd/spi-nor/core.c+1 -30 replies
3/8mtd: spi-nor: move cmd_ext_type into spi_nor_flash_parameterdrivers/mtd/spi-nor/core.c drivers/mtd/spi-nor/core.h drivers/mtd/spi-nor/debugfs.c +3 more+7 -70 replies
4/8mtd: spi-nor: move flags into spi_nor_flash_parameterdrivers/mtd/spi-nor/core.c drivers/mtd/spi-nor/core.h drivers/mtd/spi-nor/debugfs.c +7 more+98 -770 replies
5/8mtd: spi-nor: move spi_nor_post_bfpt_fixups() into sfdpdrivers/mtd/spi-nor/core.c drivers/mtd/spi-nor/core.h drivers/mtd/spi-nor/sfdp.c+31 -240 replies
6/8mtd: spi-nor: spansion: s25fs256t: move ARCFN check into .late_initdrivers/mtd/spi-nor/spansion.c+16 -140 replies
7/8mtd: spi-nor: push the rollback mechanism into the sfdp moduledrivers/mtd/spi-nor/core.c drivers/mtd/spi-nor/sfdp.c+18 -210 replies
8/8mtd: spi-nor: rework flash parameter initializationdrivers/mtd/spi-nor/core.c drivers/mtd/spi-nor/core.h+15 -430 replies

Reviews trailers per patch

4 of 8 patches have a Reviewed-by or Acked-by.

PatchTudor AmbarusMiquel RaynalTakahiro KuwanoCheng Ming Lin
1/8R-b
2/8R-b R-b
3/8
4/8
5/8R-b
6/8T-b
7/8R-b
8/8T-b T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/8] mtd: spi-nor: Rework flash parameter initialization

Try to simplify the flash initialization and get rid of the legacy handling. As default, all the flags of the in-kernel database are taken and amended with the SFDP data.

This might have the consequence that all the flashes now get a RDSFPD opcode which might be an unknown opcode. But that was already the case for any flashes which were unknown to the linux kernel. So far, there was not a single complaint. See patch 8 for more information.

Sashiko found that not everything is rolled back in case of a SFDP parsing failure. Thus there are now 5 additional patches which will move the discovered parameters into spi_nor_flash_parameter which is rolled back. The new rule is now:

SFDP parsing and the per-flash SFDP fixups must only change the spi_nor_flash_parameter data.

changes since v1:
- collected Tb and Rb tags
- Fixed the roll-back issue Sashiko found, we now keep two backups
for the parameters.
- Link to v1: https://lore.kernel.org/linux-mtd/[email protected]/

changes since the RFC:
- new patches to address the rollback issue, as pointed out by
Sashiko
- remove SKIP_SFDP from kerneldoc, as pointed out by Sashiko
- mention issuing the potential unsupported RDSFPD command in the
commit message, as pointed out by Tudor
- Link to the RFC: https://lore.kernel.org/linux-mtd/[email protected]/

Michael Walle (8):
mtd: spi-nor: spansion: s25fl256s0: remove SKIP_SFDP flag
mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failure
mtd: spi-nor: move cmd_ext_type into spi_nor_flash_parameter
mtd: spi-nor: move flags into spi_nor_flash_parameter
mtd: spi-nor: move spi_nor_post_bfpt_fixups() into sfdp
mtd: spi-nor: spansion: s25fs256t: move ARCFN check into .late_init
mtd: spi-nor: push the rollback mechanism into the sfdp module
mtd: spi-nor: rework flash parameter initialization

 drivers/mtd/spi-nor/core.c      | 178 +++++++++++---------------------
 drivers/mtd/spi-nor/core.h      |  13 +--
 drivers/mtd/spi-nor/debugfs.c   |   6 +-
 drivers/mtd/spi-nor/macronix.c  |   2 +-
 drivers/mtd/spi-nor/micron-st.c |   8 +-
 drivers/mtd/spi-nor/sfdp.c      |  70 ++++++++++---
 drivers/mtd/spi-nor/spansion.c  |  36 ++++---
 drivers/mtd/spi-nor/swp.c       |  52 ++++++----
 drivers/mtd/spi-nor/winbond.c   |   4 +-
 include/linux/mtd/spi-nor.h     |   4 -
 10 files changed, 185 insertions(+), 188 deletions(-)
Signature · 1 line
2.47.3

Read the cover letter in its thread