Skip to content

ppc/spapr: refactor cpu hotplug related code

Vishal Chourasia qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ppc/spapr: refactor cpu hotplug code to separate fileMAINTAINERS hw/ppc/meson.build hw/ppc/spapr.c +2 more+1063 -9022 replies
2/2MAINTAINERS: add self as reviewer for PPC KVM CPUsMAINTAINERS+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] ppc/spapr: refactor cpu hotplug related code

In the past we have seen issues related to cpu hotplug which are observed in certain rare case scenarios and not always easy to investigate and debug [1]. Recently we merged a fix for specific cpu hotplug scenario which observed along with kdump operations [2].

Additionally, spapr.c has grown to over 5000 lines which also contains CPU hotplug related code which accounts for nearly 1000 of those lines yet is conceptually self-contained and independent of the rest of the machine model.

Extract the cpu hotplug related code into a new compilation unit, spapr_cpu_hotplug.c, with a matching header.

Also, adding myself as reviewer for PPC KVM CPUs to help share the review work.

[1] https://lore.kernel.org/all/[email protected]/
[2] https://gitlab.com/qemu-project/qemu/-/commit/a1c2dfee4f0229bc59bd3ca20af8de1b5543973d

Vishal Chourasia (2):
ppc/spapr: refactor cpu hotplug code to separate file
MAINTAINERS: add self as reviewer for PPC KVM CPUs

 MAINTAINERS                        |   4 +
 hw/ppc/meson.build                 |   1 +
 hw/ppc/spapr.c                     | 903 +-------------------------
 hw/ppc/spapr_cpu_hotplug.c         | 984 +++++++++++++++++++++++++++++
 include/hw/ppc/spapr_cpu_hotplug.h |  74 +++
 5 files changed, 1064 insertions(+), 902 deletions(-)
 create mode 100644 hw/ppc/spapr_cpu_hotplug.c
 create mode 100644 include/hw/ppc/spapr_cpu_hotplug.h
Signature · 1 line
2.54.0