Skip to content

ipv4/ipv6: Fix UAF and memory leak in IGMP/MLD

Eric Dumazet netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesApplied 3/3
  2. v13 patches 5 repliesSuperseded

Patches in v2 All 3 applied

#Subject and filesSizeRepliesApplied
1/3ipv4: igmp: Fix potential UAF in igmp_gq_start_timer()include/linux/inetdevice.h net/ipv4/igmp.c+14 -51 replyApplied
2/3ipv6: mcast: Fix potential UAF in MLD delayed workinclude/net/addrconf.h net/ipv6/mcast.c+33 -121 replyApplied
3/3ipv4: igmp: Fix potential memory leaks in igmp_mod_timer() and igmp_stop_timer()net/ipv4/igmp.c+12 -21 replyApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchIdo Schimmel
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 net 0/3] ipv4/ipv6: Fix UAF and memory leak in IGMP/MLD

This series addresses two potential UAF vulnerabilities and memory leaks in the IPv4 IGMP and IPv6 MLD subsystems.

The first two patches fix a UAF where the packet receive path races with device teardown. If the device refcount has already hit 0 (but the memory is still held by RCU), incoming IGMP/MLD packets trying to schedule delayed work or timers would call refcount_inc() on the 0 refcount, triggering a warning and eventually leading to a UAF when the work runs after the device has been freed. This is fixed by introducing safe hold helpers using refcount_inc_not_zero(). In MLD, we also ensure we only enqueue the skb if we successfully acquired the device reference, to avoid leaking skbs when the device is being destroyed.

The third patch fixes memory leaks in IPv4 IGMP when timers are deleted or stopped. When a timer is deleted (in igmp_mod_timer) or stopped (in igmp_stop_timer) and not re-armed, the code dropped the group refcount using refcount_dec(). However, if the group was concurrently removed from the list, this decrement could drop the refcount to 0 without triggering the cleanup/free path, leaking the group structure. This is fixed by using ip_ma_put() instead, and deferring the put until after the lock is released.

Eric Dumazet (3):
ipv4: igmp: Fix potential UAF in igmp_gq_start_timer()
ipv6: mcast: Fix potential UAF in MLD delayed work
ipv4: igmp: Fix potential memory leaks in igmp_mod_timer() and
igmp_stop_timer()

 include/linux/inetdevice.h |  5 +++++
 include/net/addrconf.h     |  5 +++++
 net/ipv4/igmp.c            | 28 +++++++++++++++++++-------
 net/ipv6/mcast.c           | 40 ++++++++++++++++++++++++++------------
 4 files changed, 59 insertions(+), 19 deletions(-)
Signature · 1 line
2.55.0.rc0.799.gd6f94ed593-goog