Refactor AST2700 SCU preparation for coprocessors
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest9 patches 2 repliesIn review
- v39 patches 2 repliesSuperseded
- v28 patches 19 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 2 replies | Superseded |
Changes in v4 from the cover letter
1. Fix to apply patch failure
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | hw/misc/aspeed_scu: Introduce Aspeed2700SCUStatehw/ include/ | +12 | 0 replies | |
| 2/9 | hw/arm/aspeed: Use Aspeed2700SCUState for AST2700 usershw/ hw/ include/ +1 more | +12 | 0 replies | |
| 3/9 | hw/arm/aspeed_ast27x0: Move SCU link into AST27x0 coprocessorshw/ hw/ hw/ +1 more | +35 | 0 replies | |
| 4/9 | hw/misc/aspeed_scu: Add separate reset handler for AST2700 SCUIOhw/ | +11 | 0 replies | |
| 5/9 | hw/arm/aspeed_ast27x0: Pass realized PSP SoC to SSP/TSP initializationhw/ | +16 | 0 replies | |
| 6/9 | hw/arm/ast27x0: Share single SCUIO instance across PSP, SSP, and TSPhw/ hw/ hw/ +1 more | +36 | 0 replies | |
| 7/9 | hw/arm/ast27x0: Share FMC controller with SSP and TSPhw/ hw/ hw/ +1 more | +43 | 0 replies | |
| 8/9 | hw/ssi/aspeed_smc: Add Data FIFO-based flash access support for AST2700hw/ include/ | +109 | 0 replies | |
| 9/9 | tests/qtest/ast2700-smc-test: Add Data FIFO mode testtests/ tests/ tests/ | +110 | 1 reply |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé | Cédric Le Goater |
|---|---|---|
| 1/9 | R-b T-b | R-b |
| 2/9 | R-b T-b | R-b |
| 3/9 | R-b T-b | R-b |
| 4/9 | R-b T-b | R-b |
| 5/9 | R-b T-b | R-b |
| 6/9 | R-b T-b | R-b |
| 7/9 | R-b T-b | R-b |
| 8/9 | T-b | R-b |
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/9] Refactor AST2700 SCU preparation for coprocessors
The original AST2700 FC support series [1] is fairly large, making it difficult to review all changes together.
To help speed up the review process, this series extracts the SCU/FMC-related refactoring into a standalone prerequisite series.
This series depends on https://github.com/legoater/qemu.git at aspeed-next branch.
v1:
Compared with the original series, the SCU preparation patch has been split into three smaller patches:
Introduce Aspeed2700SCUState.
Convert AST1700/AST27x0 users to the new SCU subclass. Move the SCU link property into the AST27x0-specific coprocessor implementation.
In addition, the SCUIO reset handling has been separated into an independent patch.
This series contains no functional changes. It is purely a refactoring to isolate AST2700-specific SCU support from the generic implementation and prepare for the subsequent AST2700 FC support.
v2:
1. Pass realized PSP SoC to SSP/TSP initialization
2. Share single SCUIO instance across PSP, SSP, and TSP
3. Share FMC controller with SSP and TSP
4. Add Data FIFO-based flash access support for
v3:
1. Add Data FIFO mode test
2. Clarify SCU/SCUIO/FMC fields are shared with PSP SoC to AST2700
3. Bump vmstate version after ASPEED_SMC_R_MAX increase
v4:
1. Fix to apply patch failure
Supersedes the following patches from the original FC support series [1]:
Patch 1:
https://patchwork.kernel.org/project/qemu-devel/patch/[email protected]/
Patch 2:
https://patchwork.kernel.org/project/qemu-devel/patch/[email protected]/
Patch 4:
https://patchwork.kernel.org/project/qemu-devel/patch/[email protected]/
Patch 15:
https://patchwork.kernel.org/project/qemu-devel/patch/[email protected]/
Patch 18:
https://patchwork.kernel.org/project/qemu-devel/patch/[email protected]/
Patch
[1] Original AST2700 FC support series:
https://patchwork.kernel.org/project/qemu-devel/cover/[email protected]/
Jamin Lin (9):
hw/misc/aspeed_scu: Introduce Aspeed2700SCUState hw/arm/aspeed: Use Aspeed2700SCUState for AST2700 users hw/arm/aspeed_ast27x0: Move SCU link into AST27x0 coprocessors hw/misc/aspeed_scu: Add separate reset handler for AST2700 SCUIO hw/arm/aspeed_ast27x0: Pass realized PSP SoC to SSP/TSP initialization hw/arm/ast27x0: Share single SCUIO instance across PSP, SSP, and TSP hw/arm/ast27x0: Share FMC controller with SSP and TSP hw/ssi/aspeed_smc: Add Data FIFO-based flash access support for
AST2700
tests/qtest/ast2700-smc-test: Add Data FIFO mode test
include/hw/arm/aspeed_ast1700.h | 2 +- include/hw/arm/aspeed_coprocessor.h | 16 +++- include/hw/arm/aspeed_soc.h | 1 + include/hw/misc/aspeed_scu.h | 5 ++ include/hw/ssi/aspeed_smc.h | 3 +- tests/qtest/aspeed-smc-utils.h | 4 + hw/arm/aspeed_ast27x0-fc.c | 38 ++++++--- hw/arm/aspeed_ast27x0-ssp.c | 56 ++++++++++--- hw/arm/aspeed_ast27x0-tsp.c | 56 ++++++++++--- hw/arm/aspeed_ast27x0.c | 16 ++-- hw/arm/aspeed_coprocessor_common.c | 2 - hw/misc/aspeed_scu.c | 20 ++++- hw/ssi/aspeed_smc.c | 117 +++++++++++++++++++++++++--- tests/qtest/aspeed-smc-utils.c | 102 ++++++++++++++++++++++++ tests/qtest/ast2700-smc-test.c | 4 + 15 files changed, 384 insertions(+), 58 deletions(-)
Signature · 1 line
2.43.0