Skip to content

ALSA: Return -ENODEV instead of -EFAULT on module-get failure

[email protected] linux-sound lkml 2 versions – Applied

Status from this message: Applied to for-next branch now. Thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 2 repliesApplied
  2. v16 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- Update the commit message.
- Remove unrelated changes from the "ALSA: control: Return -ENODEV instead of -EFAULT in snd_ctl_open()" patch.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6ALSA: control: Return -ENODEV instead of -EFAULT in snd_ctl_open()sound/core/control.c+1 -10 replies
2/6ALSA: hwdep: Return -ENODEV instead of -EFAULT in snd_hwdep_open()sound/core/hwdep.c+1 -10 replies
3/6ALSA: info: Return -ENODEV instead of -EFAULT in alloc_info_private()sound/core/info.c+1 -10 replies
4/6ALSA: mixer: oss: Return -ENODEV instead of -EFAULT in snd_mixer_oss_open()sound/core/oss/mixer_oss.c+1 -10 replies
5/6ALSA: pcm: oss: Return -ENODEV instead of -EFAULT in snd_pcm_oss_open()sound/core/oss/pcm_oss.c+1 -10 replies
6/6ALSA: pcm: Return -ENODEV instead of -EFAULT in snd_pcm_open()sound/core/pcm_native.c+1 -10 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchCezary Rojewski
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] ALSA: Return -ENODEV instead of -EFAULT on module-get failure

From: bui duc phuc <[email protected]>

Hi all,

Several ALSA open/allocate paths call try_module_get() on the owning card module and return -EFAULT when it fails. However, try_module_get() fails when the module is no longer live (i.e. it is going away), meaning the device is no longer usable.
This series updates only those paths, making the error code consistent with the existing "device unavailable" checks in the same functions. Other -EFAULT returns are left unchanged.

Link v1:
https://lore.kernel.org/all/[email protected]/

Changes in v2:
- Update the commit message.
- Remove unrelated changes from the "ALSA: control: Return -ENODEV instead of -EFAULT in snd_ctl_open()" patch.

Best regards,
Phuc

bui duc phuc (6):
ALSA: control: Return -ENODEV instead of -EFAULT in snd_ctl_open()
ALSA: hwdep: Return -ENODEV instead of -EFAULT in snd_hwdep_open()
ALSA: info: Return -ENODEV instead of -EFAULT in alloc_info_private()
ALSA: mixer: oss: Return -ENODEV instead of -EFAULT in
snd_mixer_oss_open()
ALSA: pcm: oss: Return -ENODEV instead of -EFAULT in

    snd_pcm_oss_open()

ALSA: pcm: Return -ENODEV instead of -EFAULT in snd_pcm_open()

 sound/core/control.c       | 2 +-
 sound/core/hwdep.c         | 2 +-
 sound/core/info.c          | 2 +-
 sound/core/oss/mixer_oss.c | 2 +-
 sound/core/oss/pcm_oss.c   | 2 +-
 sound/core/pcm_native.c    | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)
Signature · 1 line
2.43.0