Skip to content

net/txgbe: fix coverity issues

Zaiyu Wang dpdk-dev 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2net/txgbe: fix null pointer check orderdrivers/net/txgbe/txgbe_ethdev.c+4 -30 replies
2/2net/txgbe: validate lane_num before GENMASK operationsdrivers/net/txgbe/base/txgbe_e56_bp.c+5 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] net/txgbe: fix coverity issues

This series fixes several Coverity issues reported against the txgbe driver in the 26.07-rc2 release.

Patch 1 fixes a REVERSE_INULL issue (CID 504601) in txgbe_dev_setup_link_alarm_handler_aml() by moving the null pointer check before the pointer dereference.

Patch 2 fixes INTEGER_OVERFLOW (CID 504602) and BAD_SHIFT issues (CIDs 504598, 504613) in the e56 backplane code by validating lane_num at the source in txgbe_e56_cl72_training() before any GENMASK operations are performed.

Zaiyu Wang (2):
net/txgbe: fix null pointer check order net/txgbe: validate lane_num before GENMASK operations

 drivers/net/txgbe/base/txgbe_e56_bp.c | 6 +++++-
 drivers/net/txgbe/txgbe_ethdev.c      | 7 ++++---
 2 files changed, 9 insertions(+), 4 deletions(-)
Signature · 1 line
2.21.0.windows.1