mm/khugepaged: several cleanups
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 16 repliesIn review
- v18 patches 18 repliesSuperseded
Changes in v2 from the cover letter
- Add Acks/RB tags
- rename collapse_is_young() to collapse_is_referenced()
- delete unncessary comment for collapse_control_init_scan()
- merge fixup from V1 (fixes stale folio reference) into patch 5
- keep original ordering for checks in patch 5
- merge patch 7 into patch 4
- conflict resolution from uffd_rwp changes
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | mm/khugepaged: refactor per-scan state clearing into collapse_control_init_scan()mm/ | +9 | 2 replies | |
| 2/7 | mm/khugepaged: extract young page check into collapse_is_referenced() helpermm/ | +19 | 6 replies | |
| 3/7 | mm/khugepaged: introduce a count_collapse_event() helpermm/ | +18 | 2 replies | |
| 4/7 | mm/khugepaged: fix outdated commentsmm/ | +12 | 2 replies | |
| 5/7 | mm/khugepaged: Refactor the PTE state checks into a helpermm/ | +157 | 0 replies | |
| 6/7 | mm/khugepaged: unmap pte before releasing vma write lockmm/ | +2 | 1 reply | |
| 7/7 | mm: Documentation: clarify where the mTHP stats liveDocumentation/ | +4 | 1 reply |
Reviews trailers per patch
6 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Baolin Wang | Usama Arif | David Hildenbrand (Arm) | Lorenzo Stoakes (ARM) |
|---|---|---|---|---|
| 1/7 | R-b | A-b | A-b | R-b |
| 2/7 | A-b | |||
| 3/7 | R-b | A-b | ||
| 4/7 | A-b | |||
| 5/7 | ||||
| 6/7 | A-b | |||
| 7/7 | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v2 0/7] mm/khugepaged: several cleanups
The following changes stem from a number of reviews during my khugepaged mTHP support series [1]. Some of these are minor code cleanups, issues or reviews that we decided to deferred to a followup series, or in the case of the more major patch of the series, changes [2] Lance Yang attempted while my series was in-flight and we decided to wait till later to try.
The first 3 patches introduce helper functions to increase code reuse and readability. This includes a per-scan state clearing function, extracting the young page check into a helper, and a count_collapse_event() function to reduce a repetative pattern used across mTHP collapse.
The 4th patch was the byproduct of me throwing Claude at all the comments in khugepaged verifying and looking for any outdated info.
The 5th patch is based on Lance Yang's commit series [2] trying to extract the PTE state checking into a helper function. This required a bit of rewriting due to differences after mTHP collapse was introduced. I also took into account the changes requested during his patches review cycle.
The remaining 2 patches were review points during my mTHP series that we agreed can be deferred to a later series.
Thank you to those whos reviews and work I leveraged to achieve these cleanups.
V2 Changes:
- Add Acks/RB tags
- rename collapse_is_young() to collapse_is_referenced()
- delete unncessary comment for collapse_control_init_scan()
- merge fixup from V1 (fixes stale folio reference) into patch 5
- keep original ordering for checks in patch 5
- merge patch 7 into patch 4
- conflict resolution from uffd_rwp changes
V1: https://lore.kernel.org/all/[email protected]/
[1] - https://lore.kernel.org/all/[email protected]/
[2] - https://lore.kernel.org/all/[email protected]/
Nico Pache (7):
mm/khugepaged: refactor per-scan state clearing into
collapse_control_init_scan()
mm/khugepaged: extract young page check into collapse_is_referenced()
helper
mm/khugepaged: introduce a count_collapse_event() helper mm/khugepaged: fix outdated comments
mm/khugepaged: Refactor the PTE state checks into a helper mm/khugepaged: unmap pte before releasing vma write lock
mm: Documentation: clarify where the mTHP stats live
Documentation/admin-guide/mm/transhuge.rst | 6 +- mm/khugepaged.c | 399 +++++++++++---------- 2 files changed, 214 insertions(+), 191 deletions(-)
base-commit: bdc38bfc1262e3d1432afadd2aa2ffd83d139dbb
Signature · 1 line
2.54.0