Skip to content

perf jevents: Deterministic build fix and mypy cleanliness

Ian Rogers linux-perf-users lkml 1 version Applied

Status from this message: Applied to perf-tools-next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 8 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3perf jevents: Add more components to the metric sorting ordertools/perf/pmu-events/jevents.py tools/perf/pmu-events/metric.py+8 -32 replies
2/3perf jevents: Add python type annotationstools/perf/pmu-events/jevents.py+45 -324 replies
3/3perf jevents metric: Add python type annotationstools/perf/pmu-events/metric.py+9 -80 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchNazar Kazakov
1/3T-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 0/3] perf jevents: Deterministic build fix and mypy cleanliness

Nazar Kazakov reported non-deterministic builds due to the metrics being reordered in the jevents.py output. Fix by sorting metrics on more than just their name.

Checking the code with mypy showed a large range of type warnings. Fix by largely adding asserts that values aren't None and by adding type annotations.

Ian Rogers (3):
perf jevents: Add more components to the metric sorting order perf jevents: Add python type annotations
perf jevents metric: Add python type annotations

 tools/perf/pmu-events/jevents.py | 82 +++++++++++++++++++-------------
 tools/perf/pmu-events/metric.py  | 23 +++++----
 2 files changed, 62 insertions(+), 43 deletions(-)
Signature · 1 line
2.55.0.795.g602f6c329a-goog